block: Make blkdev_get_by_*() return handle
Status from this message: Applied to the vfs.super branch of the vfs/vfs.git tree.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest29 patches 50 repliesApplied
- v229 patches 20 repliesSuperseded
- v1 RFC32 patches 29 repliesSuperseded
Changes in v3 from the cover letter
* Rebased on top of current vfs tree
* Added some acks
* Reflected minor nits from Christoph
* Added missing conversion of blkdev_put() calls in cramfs and erofs
* Fixed possible leak of bdev handle in xfs if logdev is the same as fs dev
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/29 | block: Provide bdev_open_* functionsblock/ include/ | +58 | 1 reply | |
| 1/29 | block: Provide bdev_open_* functionsblock/ include/ | +58 | 0 replies | |
| 2/29 | block: Use bdev_open_by_dev() in blkdev_open()block/ block/ block/ +2 more | +24 | 5 replies | |
| 2/29 | block: Use bdev_open_by_dev() in blkdev_open()block/ block/ include/ | +32 | 0 replies | |
| 3/29 | block: Use bdev_open_by_dev() in disk_scan_partitions() and blkdev_bszset()block/ block/ | +10 | 1 reply | |
| 3/29 | block: Use bdev_open_by_dev() in disk_scan_partitions() and blkdev_bszset()block/ block/ | +10 | 0 replies | |
| 4/29 | drdb: Convert to use bdev_open_by_path()drivers/ drivers/ | +34 | 1 reply | |
| 4/29 | drdb: Convert to use bdev_open_by_path()drivers/ drivers/ | +34 | 0 replies | |
| 5/29 | pktcdvd: Convert to bdev_open_by_dev()drivers/ include/ | +44 | 1 reply | |
| 5/29 | pktcdvd: Convert to bdev_open_by_dev()drivers/ include/ | +44 | 0 replies | |
| 6/29 | rnbd-srv: Convert to use bdev_open_by_path()drivers/ drivers/ | +15 | 1 reply | |
| 6/29 | rnbd-srv: Convert to use bdev_open_by_path()drivers/ drivers/ | +15 | 0 replies | |
| 7/29 | xen/blkback: Convert to bdev_open_by_dev()drivers/ drivers/ drivers/ | +25 | 1 reply | |
| 7/29 | xen/blkback: Convert to bdev_open_by_dev()drivers/ drivers/ drivers/ | +25 | 0 replies | |
| 8/29 | zram: Convert to use bdev_open_by_dev()drivers/ drivers/ | +15 | 1 reply | |
| 8/29 | zram: Convert to use bdev_open_by_dev()drivers/ drivers/ | +15 | 0 replies | |
| 9/29 | bcache: Convert to bdev_open_by_path()drivers/ drivers/ | +43 | 1 reply | |
| 9/29 | bcache: Convert to bdev_open_by_path()drivers/ drivers/ | +43 | 0 replies | |
| 10/29 | dm: Convert to bdev_open_by_dev()drivers/ include/ | +12 | 1 reply | |
| 10/29 | dm: Convert to bdev_open_by_dev()drivers/ include/ | +12 | 0 replies | |
| 11/29 | md: Convert to bdev_open_by_dev()drivers/ drivers/ | +8 | 1 reply | |
| 11/29 | md: Convert to bdev_open_by_dev()drivers/ drivers/ | +9 | 0 replies | |
| 12/29 | mtd: block2mtd: Convert to bdev_open_by_dev/path()drivers/ | +29 | 1 reply | |
| 12/29 | mtd: block2mtd: Convert to bdev_open_by_dev/path()drivers/ | +29 | 0 replies | |
| 13/29 | nvmet: Convert to bdev_open_by_path()drivers/ drivers/ | +12 | 2 replies | |
| 13/29 | nvmet: Convert to bdev_open_by_path()drivers/ drivers/ | +12 | 0 replies | |
| 14/29 | s390/dasd: Convert to bdev_open_by_path()drivers/ drivers/ drivers/ +1 more | +31 | 3 replies | |
| 14/29 | s390/dasd: Convert to bdev_open_by_path()drivers/ drivers/ drivers/ +1 more | +31 | 0 replies | |
| 15/29 | scsi: target: Convert to bdev_open_by_path()drivers/ drivers/ drivers/ +1 more | +26 | 1 reply | |
| 15/29 | scsi: target: Convert to bdev_open_by_path()drivers/ drivers/ drivers/ +1 more | +26 | 1 reply | |
| 16/29 | PM: hibernate: Convert to bdev_open_by_dev()kernel/ | +16 | 1 reply | |
| 16/29 | PM: hibernate: Convert to bdev_open_by_dev()kernel/ | +16 | 0 replies | |
| 17/29 | PM: hibernate: Drop unused snapshot_test argumentkernel/ kernel/ kernel/ | +11 | 1 reply | |
| 17/29 | PM: hibernate: Drop unused snapshot_test argumentkernel/ kernel/ kernel/ | +11 | 0 replies | |
| 18/29 | mm/swap: Convert to use bdev_open_by_dev()include/ mm/ | +13 | 1 reply | |
| 18/29 | mm/swap: Convert to use bdev_open_by_dev()include/ mm/ | +13 | 0 replies | |
| 19/29 | fs: Convert to bdev_open_by_dev()fs/ fs/ fs/ +1 more | +12 | 1 reply | |
| 19/29 | fs: Convert to bdev_open_by_dev()fs/ fs/ fs/ +1 more | +12 | 0 replies | |
| 20/29 | btrfs: Convert to bdev_open_by_path()fs/ fs/ fs/ +1 more | +73 | 1 reply | |
| 20/29 | btrfs: Convert to bdev_open_by_path()fs/ fs/ fs/ +1 more | +73 | 0 replies | |
| 21/29 | erofs: Convert to use bdev_open_by_path()fs/ fs/ fs/ | +13 | 1 reply | |
| 21/29 | erofs: Convert to use bdev_open_by_path()fs/ fs/ fs/ | +13 | 0 replies | |
| 22/29 | ext4: Convert to bdev_open_by_dev()fs/ fs/ fs/ | +29 | 1 reply | |
| 22/29 | ext4: Convert to bdev_open_by_dev()fs/ fs/ fs/ | +33 | 0 replies | |
| 23/29 | f2fs: Convert to bdev_open_by_dev/path()fs/ fs/ | +10 | 3 replies | |
| 23/29 | f2fs: Convert to bdev_open_by_dev/path()fs/ fs/ | +8 | 0 replies | |
| 24/29 | jfs: Convert to bdev_open_by_dev()fs/ fs/ fs/ | +18 | 1 reply | |
| 24/29 | jfs: Convert to bdev_open_by_dev()fs/ fs/ fs/ | +18 | 0 replies | |
| 25/29 | nfs/blocklayout: Convert to use bdev_open_by_dev/path()fs/ fs/ | +38 | 1 reply | |
| 25/29 | nfs/blocklayout: Convert to use bdev_open_by_dev/path()fs/ fs/ | +38 | 0 replies | |
| 26/29 | ocfs2: Convert to use bdev_open_by_dev()fs/ | +45 | 1 reply | |
| 26/29 | ocfs2: Convert to use bdev_open_by_dev()fs/ | +45 | 0 replies | |
| 27/29 | reiserfs: Convert to bdev_open_by_dev/path()fs/ fs/ fs/ | +33 | 1 reply | |
| 27/29 | reiserfs: Convert to bdev_open_by_dev/path()fs/ fs/ fs/ | +33 | 0 replies | |
| 28/29 | xfs: Convert to bdev_open_by_path()fs/ fs/ fs/ | +42 | 5 replies | |
| 28/29 | xfs: Convert to bdev_open_by_path()fs/ fs/ fs/ | +36 | 1 reply | |
| 29/29 | block: Remove blkdev_get_by_*() functionsblock/ include/ | +30 | 1 reply | |
| 29/29 | block: Remove blkdev_get_by_*() functionsblock/ include/ | +30 | 0 replies |
Reviews trailers per patch
All 58 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 16 reviewers.
Cover letter [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle
Hello,
this is a v3 of the patch series which implements the idea of blkdev_get_by_*() calls returning bdev_handle which is then passed to blkdev_put() [1]. This makes the get and put calls for bdevs more obviously matching and allows us to propagate context from get to put without having to modify all the users (again!). In particular I need to propagate used open flags to blkdev_put() to be able count writeable opens and add support for blocking writes to mounted block devices. I'll send that series separately.
The series is based on Christian's vfs tree as of today as there is quite some overlap. Patches have passed some reasonable testing - I've tested block changes, md, dm, bcache, xfs, btrfs, ext4, swap. More testing or review is always welcome. Thanks! I've pushed out the full branch to:
git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdev_handle
to ease review / testing. Since there were not many comments for v2 and Christoph has acked the series I think we should start discussing how to merge the series. Most collisions with this series seem to happen in the filesystems area so VFS tree would seem as the least painful way to merge this. Jens, are you OK with that?
Changes since v2:
* Rebased on top of current vfs tree
* Added some acks
* Reflected minor nits from Christoph
* Added missing conversion of blkdev_put() calls in cramfs and erofs
* Fixed possible leak of bdev handle in xfs if logdev is the same as fs dev
Changes since v1:
* Rebased on top of current vfs tree
* Renamed final functions to bdev_open_by_*() and bdev_release()
* Fixed detection of exclusive open in blkdev_ioctl() and blkdev_fallocate()
* Fixed swap conversion to properly reinitialize swap_info->bdev_handle
* Fixed xfs conversion to not oops with rtdev without logdev
* Couple other minor fixups
Honza
[1] https://lore.kernel.org/all/[email protected]
Previous versions: