Skip to content

Restore ability to compile on macOS/FreeBSD with Cmake

Arne Schwabe openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Do not blindly assume python3 is also the interpreter that runs rst2htmldoc/CMakeLists.txt+4 -42 replies
2/4Only add -Wno-stringop-truncation on supported compilersCMakeLists.txt+14 -82 replies
3/4Check if the -wrap argument is actually supported by the platform's ldCMakeLists.txt+7 -41 reply
4/4Avoid unused function warning/error on FreeBSDsrc/openvpn/route.c+3 -11 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFrank LichtenheldGert Doering
SeriesA-b A-b
1/4A-b
2/4A-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/4] Restore ability to compile on macOS/FreeBSD with Cmake

The patches to the cmake files did a lot of improvements but broke compiling on macOS and FreeBSD. This patch set restores the ability to compile again with these two platforms.

Arne Schwabe (4):
Do not blindly assume python3 is also the interpreter that runs
rst2html
[CMake] Only add -Wno-stringop-truncation on supported compilers Check if the -wrap argument is actually supported by the platform's ld Avoid unused function warning/error on FreeBSD

 CMakeLists.txt      | 33 +++++++++++++++++++++------------
 doc/CMakeLists.txt  |  8 ++++----
 src/openvpn/route.c |  4 +++-
 3 files changed, 28 insertions(+), 17 deletions(-)
Signature · 1 line
2.39.2 (Apple Git-143)