Skip to content

Try to handle TLB invalidations from CT fast-path

Matthew Auld intel-xe 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 2 repliesIn review
  2. v510 patches 4 repliesSuperseded
  3. v47 patches 15 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches2 repliesSuperseded
v21 patch4 repliesSuperseded
v11 patch1 replySuperseded

Changes in v6 from the cover letter

- One small fix to patch 8 to make sure we write the correct seqno on reset.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/xe/tlb: drop unnecessary smp_wmb()drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+4 -10 replies
2/11drm/xe/tlb: ensure we access seqno_recv oncedrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+6 -60 replies
3/11drm/xe: hold mem_access.ref for CT fast-pathdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h drivers/gpu/drm/xe/xe_guc_ct.c+10 -10 replies
4/11drm/xe/ct: hold fast_lock when reserving space for g2hdrivers/gpu/drm/xe/xe_guc_ct.c+15 -70 replies
5/11drm/xe/tlb: increment next seqno after successful CT senddrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+6 -50 replies
6/11drm/xe/ct: serialise fast_lock during CT disabledrivers/gpu/drm/xe/xe_guc_ct.c+6 -20 replies
7/11drm/xe/gt: tweak placement for signalling TLB fences after GT resetdrivers/gpu/drm/xe/xe_gt.c+2 -10 replies
8/11drm/xe/tlb: also update seqno_recv during resetdrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+22 -20 replies
9/11drm/xe/tlb: print seqno_recv on fence TLB timeoutdrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+2 -20 replies
10/11drm/xe/ct: update g2h outstanding for CTB capturedrivers/gpu/drm/xe/xe_guc_ct.c+1 -01 reply
11/11drm/xe: handle TLB invalidations from CT fast-pathdrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c drivers/gpu/drm/xe/xe_gt_types.h drivers/gpu/drm/xe/xe_guc_ct.c+91 -600 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchMatthew BrostJosé Roberto de Souza
SeriesT-b
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Intel-xe] [PATCH v6 00/11] Try to handle TLB invalidations from CT fast-path

In various test cases and workloads that put the system under a heavy load, we can sometimes see errors with missed TLB invalidations. If we handle the TLB completions directly from IRQ we can see a big improvement.

v4:
- Various tweaks. Big thing is to make sure we grab the fast_lock for the g2h reservation when doing the CT send, which closes one big race with the CT fast-path.
v5:
- Various improvements. Fix the race with adding a fence after its seqno has already been signalled. (Matt Brost)
v6:
- One small fix to patch 8 to make sure we write the correct seqno on reset.

Signature · 1 line
2.41.0