Skip to content

clocksource: sun5i: clean up and convert to platform driver

Mans Rullgard linux-arm-kernel linux-sunxi lkml 1 version Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3clocksource: sun5i: remove duplication of code and datadrivers/clocksource/timer-sun5i.c+76 -1301 reply
2/3clocksource: sun5i: remove pointless structdrivers/clocksource/timer-sun5i.c+22 -271 reply
3/3clocksource: sun5i: convert to platform device driverdrivers/clocksource/timer-sun5i.c+69 -521 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaxime RipardJernej Skrabec
SeriesA-b
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] clocksource: sun5i: clean up and convert to platform driver

The first two of these patches remove a bunch of duplicated code/data in the sun5i hstimer driver. To keep the diff clearer, the first patch introduces an otherwise pointless struct which is then removed in the second.

The third patch converts the driver to a platform_device driver. This is to make it work again on A20 and A31 (I think) where it broke when the ccu driver was changed to a platform driver.

I have only tested this on an A20 where the hstimer is registered as expected and can be selected through sysfs. I hope it doesn't break something else.

Some additional discussion here:
https://lore.kernel.org/linux-clk/[email protected]/

Mans Rullgard (3):
clocksource: sun5i: remove duplication of code and data
clocksource: sun5i: remove pointless struct
clocksource: sun5i: convert to platform device driver

 drivers/clocksource/timer-sun5i.c | 288 +++++++++++++-----------------
 1 file changed, 123 insertions(+), 165 deletions(-)
Signature · 1 line
2.41.0