Skip to content

target/s390x: Miscellaneous TCG fixes

Ilya Leoshkevich qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 1 replyIn review
  2. v112 patches 17 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12linux-user: elfload: Add more initial s390x PSW bitslinux-user/elfload.c+3 -10 replies
2/12target/s390x: Fix EPSW CC reportingtarget/s390x/tcg/translate.c+4 -00 replies
3/12target/s390x: Fix MDEB and MDEBRtarget/s390x/tcg/fpu_helper.c target/s390x/tcg/insn-data.h.inc+4 -30 replies
4/12target/s390x: Fix MVCRL with a large value in R0target/s390x/tcg/mem_helper.c+1 -00 replies
5/12target/s390x: Fix LRA overwriting the top 32 bits on DAT errortarget/s390x/helper.h target/s390x/tcg/mem_helper.c target/s390x/tcg/translate.c+4 -41 reply
6/12target/s390x: Fix LRA when DAT is offtarget/s390x/mmu_helper.c+1 -10 replies
7/12target/s390x: Fix relative long instructions with large offsetstarget/s390x/tcg/translate.c+1 -10 replies
8/12tests/tcg/s390x: Test EPSWtests/tcg/s390x/Makefile.target tests/tcg/s390x/epsw.c+24 -00 replies
9/12tests/tcg/s390x: Test LARL with a large offsettests/tcg/s390x/Makefile.target tests/tcg/s390x/larl.c+22 -00 replies
10/12tests/tcg/s390x: Test LRAtests/tcg/s390x/Makefile.softmmu-target tests/tcg/s390x/lra.S+20 -00 replies
11/12tests/tcg/s390x: Test MDEB and MDEBRtests/tcg/s390x/Makefile.target tests/tcg/s390x/mdeb.c+31 -00 replies
12/12tests/tcg/s390x: Test MVCRL with a large value in R0tests/tcg/s390x/mie3-mvcrl.c+36 -100 replies

Reviews trailers per patch

11 of 12 patches have a Reviewed-by or Acked-by.

PatchDavid Hildenbrand
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12A-b
10/12
11/12A-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] target/s390x: Miscellaneous TCG fixes

v1: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg00454.html
v1 -> v2: Add ULL for a large constant (David).
Add a comment explaining the usage of ALGFI in the LARL test.

Hi,

Randomized testing found a number of issues in the s390x emulation. This series fixes 6 of them (patches 2-7) and adds tests (patches 8-12); patch 1 is a cosmetic improvement needed for the EPSW test.

There are more issues, but I thought it would be better to send this batch now.

Best regards,
Ilya

Ilya Leoshkevich (12):
linux-user: elfload: Add more initial s390x PSW bits target/s390x: Fix EPSW CC reporting
target/s390x: Fix MDEB and MDEBR
target/s390x: Fix MVCRL with a large value in R0 target/s390x: Fix LRA overwriting the top 32 bits on DAT error target/s390x: Fix LRA when DAT is off
target/s390x: Fix relative long instructions with large offsets tests/tcg/s390x: Test EPSW
tests/tcg/s390x: Test LARL with a large offset tests/tcg/s390x: Test LRA
tests/tcg/s390x: Test MDEB and MDEBR
tests/tcg/s390x: Test MVCRL with a large value in R0

 linux-user/elfload.c                    |  4 ++-
 target/s390x/helper.h                   |  2 +-
 target/s390x/mmu_helper.c               |  2 +-
 target/s390x/tcg/fpu_helper.c           |  3 +-
 target/s390x/tcg/insn-data.h.inc        |  4 +--
 target/s390x/tcg/mem_helper.c           |  5 +--
 target/s390x/tcg/translate.c            |  8 +++--
 tests/tcg/s390x/Makefile.softmmu-target |  1 +
 tests/tcg/s390x/Makefile.target         |  3 ++
 tests/tcg/s390x/epsw.c                  | 23 +++++++++++++
 tests/tcg/s390x/larl.c                  | 21 +++++++++++
 tests/tcg/s390x/lra.S                   | 19 ++++++++++
 tests/tcg/s390x/mdeb.c                  | 30 ++++++++++++++++
 tests/tcg/s390x/mie3-mvcrl.c            | 46 +++++++++++++++++++------
 14 files changed, 151 insertions(+), 20 deletions(-)
 create mode 100644 tests/tcg/s390x/epsw.c
 create mode 100644 tests/tcg/s390x/larl.c
 create mode 100644 tests/tcg/s390x/lra.S
 create mode 100644 tests/tcg/s390x/mdeb.c
Signature · 1 line
2.41.0