HID: cp2112: Cleanups and refactorings
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 17 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | lib/string_choices: Add str_write_read() helperinclude/ | +1 | 0 replies | |
| 2/12 | HID: cp2112: Use str_write_read() and str_read_write()drivers/ | +4 | 0 replies | |
| 3/12 | HID: cp2112: Make irq_chip immutabledrivers/ | +20 | 0 replies | |
| 4/12 | HID: cp2112: Switch to for_each_set_bit() to simplify the codedrivers/ | +2 | 0 replies | |
| 5/12 | HID: cp2112: Don't call ->to_irq() explicitlydrivers/ | +3 | 0 replies | |
| 6/12 | HID: cp2112: Remove dead codedrivers/ | +0 | 2 replies | |
| 7/12 | HID: cp2112: Define maximum GPIO constant and use itdrivers/ | +3 | 0 replies | |
| 8/12 | HID: cp2112: Define all GPIO mask and use itdrivers/ | +3 | 0 replies | |
| 9/12 | HID: cp2112: Use BIT() in GPIO setter and getterdrivers/ | +2 | 0 replies | |
| 10/12 | HID: cp2112: Use sysfs_emit() to instead of scnprintf()drivers/ | +1 | 0 replies | |
| 11/12 | HID: cp2112: Convert to DEVICE_ATTR_RW()drivers/ | +19 | 0 replies | |
| 12/12 | HID: cp2112: Use octal permissionsdrivers/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings
After I updated GPIO library for the case Benjamin has with CP2112, I have a brief look into the CP2112 driver itself.
From GPIO perspective it has two main (maitenance) issues:
- usage of ->to_irq() with IRQ chip present;
- having IRQ chip not immutable.
Besides that there are plenty small cleanups here and there. Hence this series.
Compile tested only.
Andy Shevchenko (12):
lib/string_choices: Add str_write_read() helper
HID: cp2112: Use str_write_read() and str_read_write()
HID: cp2112: Make irq_chip immutable
HID: cp2112: Switch to for_each_set_bit() to simplify the code
HID: cp2112: Don't call ->to_irq() explicitly
HID: cp2112: Remove dead code
HID: cp2112: Define maximum GPIO constant and use it
HID: cp2112: Define all GPIO mask and use it
HID: cp2112: Use BIT() in GPIO setter and getter
HID: cp2112: Use sysfs_emit() to instead of scnprintf()
HID: cp2112: Convert to DEVICE_ATTR_RW()
HID: cp2112: Use octal permissions
drivers/hid/hid-cp2112.c | 169 +++++++++++---------------------- include/linux/string_choices.h | 1 + 2 files changed, 58 insertions(+), 112 deletions(-)
Signature · 1 line
2.40.0.1.gaa8946217a0b