Skip to content

net: fec: fix some issues of ndo_xdp_xmit()

[email protected] bpf lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesApplied 4/4
  2. v13 patches 14 repliesSuperseded

Patches in v2 All 4 applied

#Subject and filesSizeRepliesApplied
1/4net: fec: dynamically set the NETDEV_XDP_ACT_NDO_XMIT feature of XDPdrivers/net/ethernet/freescale/fec_main.c+9 -40 repliesApplied
2/4net: fec: recycle pages for transmitted XDP framesdrivers/net/ethernet/freescale/fec.h drivers/net/ethernet/freescale/fec_main.c+115 -483 repliesApplied
3/4net: fec: increase the size of tx ring and update tx_wake_thresholddrivers/net/ethernet/freescale/fec.h drivers/net/ethernet/freescale/fec_main.c+2 -30 repliesApplied
4/4net: fec: use netdev_err_once() instead of netdev_err()drivers/net/ethernet/freescale/fec_main.c+1 -10 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 net 0/4] net: fec: fix some issues of ndo_xdp_xmit()

From: Wei Fang <[email protected]>

We encountered some issues when testing the ndo_xdp_xmit() interface of the fec driver on i.MX8MP and i.MX93 platforms. These issues are easy to reproduce, and the specific reproduction steps are as follows.

step1: The ethernet port of a board (board A) is connected to the EQOS port of i.MX8MP/i.MX93, and the FEC port of i.MX8MP/i.MX93 is connected to another ethernet port, such as a switch port.

step2: Board A uses the pktgen_sample03_burst_single_flow.sh to generate and send packets to i.MX8MP/i.MX93. The command is shown below. ./pktgen_sample03_burst_single_flow.sh -i eth0 -d 192.168.6.8 -m \
56:bf:0d:68:b0:9e -s 1500

step3: i.MX8MP/i.MX93 use the xdp_redirect bfp program to redirect the XDP frames from EQOS port to FEC port. The command is shown below. ./xdp_redirect eth1 eth0

After a few moments, the warning or error logs will be printed in the console, for more details, please refer to the commit message of each patch.

Wei Fang (4):
net: fec: dynamically set the NETDEV_XDP_ACT_NDO_XMIT feature of XDP
net: fec: recycle pages for transmitted XDP frames
net: fec: increase the size of tx ring and update tx_wake_threshold
net: fec: use netdev_err_once() instead of netdev_err()

 drivers/net/ethernet/freescale/fec.h      |  17 ++-
 drivers/net/ethernet/freescale/fec_main.c | 166 +++++++++++++++-------
 2 files changed, 127 insertions(+), 56 deletions(-)
Signature · 1 line
2.25.1