pstore: Replace crypto API compression with zlib calls
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 3 repliesApplied
- v22 patches 5 repliesSuperseded
- v12 patches 6 repliesSuperseded
Changes in v3 from the cover letter
- some more prose improvements and NULL checks/assignments suggested by Eric
- reset author on patch #1
- add Guilherme's Tested-by
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | pstore: Remove worst-case compression size logicfs/ | +19 | 1 reply | |
| 2/2 | pstore: Replace crypto API compression with zlib_deflate library callsfs/ fs/ | +97 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Guilherme G. Piccoli | Eric Biggers |
|---|---|---|
| 1/2 | T-b | R-b |
| 2/2 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] pstore: Replace crypto API compression with zlib calls
The pstore layer implements support for compression of kernel log output, using a variety of compression algorithms provided by the [deprecated] crypto API 'comp' interface.
This appears to have been somebody's pet project rather than a solution to a real problem: the original deflate compression is reasonably fast, compresses well and is comparatively small in terms of code footprint, and so the flexibility that the crypto API integration provides does little more than complicate the code for no reason.
So let's get rid of this complexity, and switch back to zlib deflate using the library interface.
Changes since v2:
- some more prose improvements and NULL checks/assignments suggested by Eric
- reset author on patch #1
- add Guilherme's Tested-by
Changes since v1:
- add missing vfree() of zlib compression workspace
- implement improvements and simplifications suggested by Eric
- add missing zlib_in/deflateEnd() calls
- add code comment to document that the use of a library interface is deliberate, and doesn't require a future 'upgrade' to the crypto API
Ard Biesheuvel (2):
pstore: Remove worst-case compression size logic
pstore: Replace crypto API compression with zlib_deflate library calls
fs/pstore/Kconfig | 100 +----- fs/pstore/platform.c | 330 ++++++-------------- 2 files changed, 110 insertions(+), 320 deletions(-)
Signature · 1 line
2.39.2