Skip to content

drm: Improve fbdev emulation for DMA-able framebuffers

Thomas Zimmermann dri-devel linux-arm-kernel linux-fbdev linux-samsung-soc linux-tegra 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 4 repliesIn review
  2. v211 patches 4 repliesSuperseded
  3. v110 patches 19 repliesSuperseded

Changes in v3 from the cover letter

* set screen_buffer in tegra (Thierry)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12fbdev: Add fb_ops init macros for framebuffers in DMA-able memorydrivers/video/fbdev/Kconfig include/linux/fb.h+21 -00 replies
2/12drm/fbdev-dma: Use fbdev DMA helpersdrivers/gpu/drm/Kconfig drivers/gpu/drm/drm_fbdev_dma.c+3 -30 replies
3/12drm/tegra: Use fbdev DMA helpersdrivers/gpu/drm/tegra/Kconfig drivers/gpu/drm/tegra/fbdev.c+3 -31 reply
4/12drm/tegra: Set fbdev FBINFO_VIRTFB flagdrivers/gpu/drm/tegra/fbdev.c+1 -01 reply
5/12drm/tegra: Store pointer to vmap'ed framebuffer in screen_bufferdrivers/gpu/drm/tegra/fbdev.c+1 -12 replies
6/12drm/exynos: Use fbdev DMA helpersdrivers/gpu/drm/exynos/Kconfig drivers/gpu/drm/exynos/exynos_drm_fbdev.c+3 -30 replies
7/12drm/exynos: Set fbdev FBINFO_VIRTFB flagdrivers/gpu/drm/exynos/exynos_drm_fbdev.c+1 -00 replies
8/12drm/omapdrm: Set VM flags in GEM-object mmap functiondrivers/gpu/drm/omapdrm/omap_drv.c drivers/gpu/drm/omapdrm/omap_gem.c drivers/gpu/drm/omapdrm/omap_gem.h +1 more+8 -380 replies
9/12drm/omapdrm: Use GEM mmap for fbdev emulationdrivers/gpu/drm/omapdrm/Kconfig drivers/gpu/drm/omapdrm/omap_fbdev.c+14 -30 replies
10/12drm/omapdrm: Set fbdev FBINFO_VIRTFB flagdrivers/gpu/drm/omapdrm/omap_fbdev.c+1 -00 replies
11/12fbdev: Remove FB_DEFAULT_SYS_OPSinclude/linux/fb.h+0 -80 replies
12/12fbdev: Harmonize some comments in <linux/fb.h>include/linux/fb.h+2 -100 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez CanillasMaxime RipardInki DaeThierry Reding
1/12R-b A-b
2/12R-b A-b
3/12R-b A-b A-b
4/12R-b A-b A-b
5/12R-b A-b
6/12R-b A-b A-b
7/12R-b A-b A-b
8/12R-b A-b
9/12R-b A-b
10/12R-b A-b
11/12R-b A-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/12] drm: Improve fbdev emulation for DMA-able framebuffers

Add fbdev helpers for framebuffers in DMA-able memory and update fbdev emulation in the respective DRM drivers. DMA memory used to handled as system memory. Improve this and prepare for possible future changes.

Patch 1 adds initializer macros for struct fb_ops and a Kconfig token for framebuffers in DMA memory.

Patches 2 to 5 update fbdev-dma and tegra. No functional changes are expected as both used system memory before.

Patches 6 and 7 update exynos to use DMA helpers. Exynos incorrectly used fbdev's I/O-memory helpers. Fix this.

Patches 8 to 10 update omapdrm to use DMA helpers. Patch 7 first reworks the driver's mmap to current best practices. This also makes it suitable for use with fbdev, which patches 8 and 9 implement.

Patchies 11 removes some fbdev macros for system memory that are now unused; patch 12 fixes some comments.

The patchset would ideally go through drm-misc-next. Future patches can build upon it and update fbdev drivers in similar ways.

v3:
* set screen_buffer in tegra (Thierry)
v2:
* fix omap mmap flags
* drop FBINFO_DEFAULT from patches
* minor cleanups

Thomas Zimmermann (12):
fbdev: Add fb_ops init macros for framebuffers in DMA-able memory drm/fbdev-dma: Use fbdev DMA helpers
drm/tegra: Use fbdev DMA helpers
drm/tegra: Set fbdev FBINFO_VIRTFB flag
drm/tegra: Store pointer to vmap'ed framebuffer in screen_buffer drm/exynos: Use fbdev DMA helpers
drm/exynos: Set fbdev FBINFO_VIRTFB flag
drm/omapdrm: Set VM flags in GEM-object mmap function drm/omapdrm: Use GEM mmap for fbdev emulation drm/omapdrm: Set fbdev FBINFO_VIRTFB flag
fbdev: Remove FB_DEFAULT_SYS_OPS
fbdev: Harmonize some comments in <linux/fb.h>

 drivers/gpu/drm/Kconfig                   |  2 +-
 drivers/gpu/drm/drm_fbdev_dma.c           |  4 ++--
 drivers/gpu/drm/exynos/Kconfig            |  2 +-
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c |  5 ++--
 drivers/gpu/drm/omapdrm/Kconfig           |  2 +-
 drivers/gpu/drm/omapdrm/omap_drv.c        | 12 +---------
 drivers/gpu/drm/omapdrm/omap_fbdev.c      | 16 +++++++++++--
 drivers/gpu/drm/omapdrm/omap_gem.c        | 24 +++++--------------
 drivers/gpu/drm/omapdrm/omap_gem.h        |  3 ---
 drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c |  7 +-----
 drivers/gpu/drm/tegra/Kconfig             |  2 +-
 drivers/gpu/drm/tegra/fbdev.c             |  7 +++---
 drivers/video/fbdev/Kconfig               |  8 +++++++
 include/linux/fb.h                        | 29 ++++++++++-------------
 14 files changed, 56 insertions(+), 67 deletions(-)
Signature · 1 line
2.41.0