Skip to content

Netfilter stable fixes for 5.10

Pablo Neira Ayuso netfilter-devel stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 2 repliesIn review
  2. v22 patches 0 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11netfilter: nf_tables: use net_generic infra for transaction datainclude/net/netfilter/nf_tables.h include/net/netns/nftables.h net/netfilter/nf_tables_api.c +3 more+279 -1672 replies
2/11netfilter: nf_tables: add rescheduling points during loop detection walksnet/netfilter/nf_tables_api.c+6 -00 replies
3/11netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULEnet/netfilter/nf_tables_api.c+2 -10 replies
4/11netfilter: nf_tables: fix chain binding transaction logicinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nft_immediate.c+153 -410 replies
5/11netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chaininclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nft_immediate.c+43 -70 replies
6/11netfilter: nf_tables: reject unbound anonymous set before commit phaseinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c+34 -30 replies
7/11netfilter: nf_tables: reject unbound chain set before commit phasenet/netfilter/nf_tables_api.c+13 -00 replies
8/11netfilter: nftables: rename set element data activation/deactivation functionsnet/netfilter/nf_tables_api.c+11 -110 replies
9/11netfilter: nf_tables: drop map element references from preparation phaseinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nft_set_bitmap.c +3 more+117 -240 replies
10/11netfilter: nf_tables: unbind non-anonymous set if rule construction failsnet/netfilter/nf_tables_api.c+2 -00 replies
11/11netfilter: nf_tables: fix scheduling-while-atomic splatnet/netfilter/nf_tables_api.c+0 -40 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchPablo Neira Ayuso
1/11
2/11A-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH -stable,5.10 v3 00/11] Netfilter stable fixes for 5.10

Hi Greg, Sasha,

[ This is v3:
- remove backported function that is useless in patch 09/11
- use: Upstream commit XYZ tag as suggested by Salvatore Bonaccorso.
]

The following list shows the backported patches. I am using original commit IDs for reference:

1) 0854db2aaef3 ("netfilter: nf_tables: use net_generic infra for transaction data")

2) 81ea01066741 ("netfilter: nf_tables: add rescheduling points during loop detection walks")

3) 1240eb93f061 ("netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULE")

4) 4bedf9eee016 ("netfilter: nf_tables: fix chain binding transaction logic")

5) 26b5a5712eb8 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain")

6) 938154b93be8 ("netfilter: nf_tables: reject unbound anonymous set before commit phase")

7) 62e1e94b246e ("netfilter: nf_tables: reject unbound chain set before commit phase")

8) f8bb7889af58 ("netfilter: nftables: rename set element data activation/deactivation functions")

9) 628bd3e49cba ("netfilter: nf_tables: drop map element references from preparation phase")

10) 3e70489721b6 ("netfilter: nf_tables: unbind non-anonymous set if rule construction fails")

11) f838e0906dd3 ("netfilter: nf_tables: fix scheduling-while-atomic splat")

Notes:

- Patch #1 is a backported dependency patch required by these fixes.
- Patch #3 needs an incremental follow up fix coming in Patch #11.

Florian Westphal (3):
netfilter: nf_tables: use net_generic infra for transaction data
netfilter: nf_tables: add rescheduling points during loop detection walks
netfilter: nf_tables: fix scheduling-while-atomic splat

Pablo Neira Ayuso (8):
netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULE
netfilter: nf_tables: fix chain binding transaction logic
netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain
netfilter: nf_tables: reject unbound anonymous set before commit phase
netfilter: nf_tables: reject unbound chain set before commit phase
netfilter: nftables: rename set element data activation/deactivation functions
netfilter: nf_tables: drop map element references from preparation phase
netfilter: nf_tables: unbind non-anonymous set if rule construction fails

 include/net/netfilter/nf_tables.h |  41 +-
 include/net/netns/nftables.h      |   7 -
 net/netfilter/nf_tables_api.c     | 662 +++++++++++++++++++++---------
 net/netfilter/nf_tables_offload.c |  30 +-
 net/netfilter/nft_chain_filter.c  |  11 +-
 net/netfilter/nft_dynset.c        |   6 +-
 net/netfilter/nft_immediate.c     |  90 +++-
 net/netfilter/nft_set_bitmap.c    |   5 +-
 net/netfilter/nft_set_hash.c      |  23 +-
 net/netfilter/nft_set_pipapo.c    |  14 +-
 net/netfilter/nft_set_rbtree.c    |   5 +-
 11 files changed, 648 insertions(+), 246 deletions(-)
Signature · 1 line
2.30.2