RFC selinux: be more strict about integer conversions
Status from this message: Merged into selinux/next, thanks.
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest20 patches 23 repliesApplied
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | selinux: check for multiplication overflow in put_entry()security/ | +5 | 1 reply | |
| 2/20 | selinux: avtab: avoid implicit conversionssecurity/ | +18 | 1 reply | |
| 3/20 | selinux: avoid avtab overflowssecurity/ | +2 | 1 reply | |
| 4/20 | selinux: ebitmap: use u32 as bit typesecurity/ security/ | +32 | 1 reply | |
| 5/20 | selinux: hashtab: use identical iterator typesecurity/ | +3 | 1 reply | |
| 6/20 | selinux: mls: avoid implicit conversionssecurity/ | +6 | 1 reply | |
| 7/20 | selinux: services: update type for umber of class permissionssecurity/ security/ | +4 | 3 replies | |
| 8/20 | selinux: services: avoid implicit conversionssecurity/ security/ security/ | +15 | 1 reply | |
| 9/20 | selinux: status: consistently use u32 as sequence number typesecurity/ security/ | +2 | 1 reply | |
| 10/20 | selinux: netif: avoid implicit conversionssecurity/ | +2 | 1 reply | |
| 11/20 | selinux: avc: avoid implicit conversionssecurity/ | +8 | 1 reply | |
| 12/20 | selinux: hooks: avoid implicit conversionssecurity/ | +10 | 1 reply | |
| 13/20 | selinux: selinuxfs: avoid implicit conversionssecurity/ | +2 | 1 reply | |
| 14/20 | selinux: use consistent type for AV rule specifiersecurity/ security/ security/ | +3 | 1 reply | |
| 15/20 | selinux: policydb: implicit conversionssecurity/ | +65 | 1 reply | |
| 16/20 | selinux: symtab: implicit conversionsecurity/ security/ | +2 | 1 reply | |
| 17/20 | selinux: services: implicit conversionssecurity/ | +2 | 1 reply | |
| 18/20 | selinux: nlmsgtab: implicit conversionsecurity/ | +2 | 1 reply | |
| 19/20 | selinux: status: avoid implicit conversions regarding enforcing statussecurity/ security/ security/ | +7 | 1 reply | |
| 20/20 | selinux: selinuxfs: avoid implicit conversionssecurity/ | +5 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 00/20] selinux: be more strict about integer conversions
The C language allows implicit conversions between distinct integer types. These conversions can lead to unintended truncations or sign extensions. Be more strict about integer types by using identical types where applicable.
This patches utilizes the C99 feature of declaring loop iterators inside for loops, supported since Linux 5.18.
Not all implicit conversions are removed, there are still many in the selinuxfs code related to foreign interfaces, error-pointer related ones, and some truncations around reading class, type and other identifiers from binary policies (which might be subject for future work).
A possible instance of a integer conversion related issue might have been reported at [1].
[1]: https://lore.kernel.org/selinux/[email protected]/
Christian Göttsche (20):
selinux: check for multiplication overflow in put_entry()
selinux: avtab: avoid implicit conversions
selinux: avoid avtab overflows
selinux: ebitmap: use u32 as bit type
selinux: hashtab: use identical iterator type
selinux: mls: avoid implicit conversions
selinux: services: update type for umber of class permissions
selinux: services: avoid implicit conversions
selinux: status: consistently use u32 as sequence number type
selinux: netif: avoid implicit conversions
selinux: avc: avoid implicit conversions
selinux: hooks: avoid implicit conversions
selinux: selinuxfs: avoid implicit conversions
selinux: use consistent type for AV rule specifier
selinux: policydb: implicit conversions
selinux: symtab: implicit conversion
selinux: services: implicit conversions
selinux: nlmsgtab: implicit conversion
selinux: status: avoid implicit conversions regarding enforcing status
selinux: selinuxfs: avoid implicit conversions
security/selinux/avc.c | 15 ++-- security/selinux/hooks.c | 26 +++---- security/selinux/include/security.h | 8 +- security/selinux/netif.c | 4 +- security/selinux/nlmsgtab.c | 4 +- security/selinux/selinuxfs.c | 33 ++++---- security/selinux/ss/avtab.c | 44 ++++++----- security/selinux/ss/avtab.h | 2 +- security/selinux/ss/ebitmap.c | 32 ++++---- security/selinux/ss/ebitmap.h | 32 ++++---- security/selinux/ss/hashtab.c | 6 +- security/selinux/ss/mls.c | 11 +-- security/selinux/ss/policydb.c | 112 ++++++++++++++++------------ security/selinux/ss/policydb.h | 7 +- security/selinux/ss/services.c | 36 ++++----- security/selinux/ss/services.h | 2 +- security/selinux/ss/symtab.c | 2 +- security/selinux/ss/symtab.h | 2 +- security/selinux/status.c | 6 +- 19 files changed, 195 insertions(+), 189 deletions(-)
Signature · 1 line
2.40.1