Skip to content

RFC selinux: be more strict about integer conversions

Christian Göttsche lkml selinux 1 version Applied

Status from this message: Merged into selinux/next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest20 patches 23 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/20selinux: check for multiplication overflow in put_entry()security/selinux/ss/policydb.h+5 -21 reply
2/20selinux: avtab: avoid implicit conversionssecurity/selinux/ss/avtab.c+18 -201 reply
3/20selinux: avoid avtab overflowssecurity/selinux/ss/avtab.c+2 -21 reply
4/20selinux: ebitmap: use u32 as bit typesecurity/selinux/ss/ebitmap.c security/selinux/ss/ebitmap.h+32 -321 reply
5/20selinux: hashtab: use identical iterator typesecurity/selinux/ss/hashtab.c+3 -31 reply
6/20selinux: mls: avoid implicit conversionssecurity/selinux/ss/mls.c+6 -51 reply
7/20selinux: services: update type for umber of class permissionssecurity/selinux/ss/services.c security/selinux/ss/services.h+4 -43 replies
8/20selinux: services: avoid implicit conversionssecurity/selinux/include/security.h security/selinux/selinuxfs.c security/selinux/ss/services.c+15 -181 reply
9/20selinux: status: consistently use u32 as sequence number typesecurity/selinux/include/security.h security/selinux/status.c+2 -21 reply
10/20selinux: netif: avoid implicit conversionssecurity/selinux/netif.c+2 -21 reply
11/20selinux: avc: avoid implicit conversionssecurity/selinux/avc.c+8 -71 reply
12/20selinux: hooks: avoid implicit conversionssecurity/selinux/hooks.c+10 -161 reply
13/20selinux: selinuxfs: avoid implicit conversionssecurity/selinux/selinuxfs.c+2 -31 reply
14/20selinux: use consistent type for AV rule specifiersecurity/selinux/ss/avtab.c security/selinux/ss/avtab.h security/selinux/ss/services.c+3 -31 reply
15/20selinux: policydb: implicit conversionssecurity/selinux/ss/policydb.c+65 -471 reply
16/20selinux: symtab: implicit conversionsecurity/selinux/ss/symtab.c security/selinux/ss/symtab.h+2 -21 reply
17/20selinux: services: implicit conversionssecurity/selinux/ss/services.c+2 -41 reply
18/20selinux: nlmsgtab: implicit conversionsecurity/selinux/nlmsgtab.c+2 -21 reply
19/20selinux: status: avoid implicit conversions regarding enforcing statussecurity/selinux/include/security.h security/selinux/selinuxfs.c security/selinux/status.c+7 -61 reply
20/20selinux: selinuxfs: avoid implicit conversionssecurity/selinux/selinuxfs.c+5 -91 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/20] selinux: be more strict about integer conversions

The C language allows implicit conversions between distinct integer types. These conversions can lead to unintended truncations or sign extensions. Be more strict about integer types by using identical types where applicable.

This patches utilizes the C99 feature of declaring loop iterators inside for loops, supported since Linux 5.18.

Not all implicit conversions are removed, there are still many in the selinuxfs code related to foreign interfaces, error-pointer related ones, and some truncations around reading class, type and other identifiers from binary policies (which might be subject for future work).

A possible instance of a integer conversion related issue might have been reported at [1].

[1]: https://lore.kernel.org/selinux/[email protected]/

Christian Göttsche (20):
selinux: check for multiplication overflow in put_entry()
selinux: avtab: avoid implicit conversions
selinux: avoid avtab overflows
selinux: ebitmap: use u32 as bit type
selinux: hashtab: use identical iterator type
selinux: mls: avoid implicit conversions
selinux: services: update type for umber of class permissions
selinux: services: avoid implicit conversions
selinux: status: consistently use u32 as sequence number type
selinux: netif: avoid implicit conversions
selinux: avc: avoid implicit conversions
selinux: hooks: avoid implicit conversions
selinux: selinuxfs: avoid implicit conversions
selinux: use consistent type for AV rule specifier
selinux: policydb: implicit conversions
selinux: symtab: implicit conversion
selinux: services: implicit conversions
selinux: nlmsgtab: implicit conversion
selinux: status: avoid implicit conversions regarding enforcing status
selinux: selinuxfs: avoid implicit conversions

 security/selinux/avc.c              |  15 ++--
 security/selinux/hooks.c            |  26 +++----
 security/selinux/include/security.h |   8 +-
 security/selinux/netif.c            |   4 +-
 security/selinux/nlmsgtab.c         |   4 +-
 security/selinux/selinuxfs.c        |  33 ++++----
 security/selinux/ss/avtab.c         |  44 ++++++-----
 security/selinux/ss/avtab.h         |   2 +-
 security/selinux/ss/ebitmap.c       |  32 ++++----
 security/selinux/ss/ebitmap.h       |  32 ++++----
 security/selinux/ss/hashtab.c       |   6 +-
 security/selinux/ss/mls.c           |  11 +--
 security/selinux/ss/policydb.c      | 112 ++++++++++++++++------------
 security/selinux/ss/policydb.h      |   7 +-
 security/selinux/ss/services.c      |  36 ++++-----
 security/selinux/ss/services.h      |   2 +-
 security/selinux/ss/symtab.c        |   2 +-
 security/selinux/ss/symtab.h        |   2 +-
 security/selinux/status.c           |   6 +-
 19 files changed, 195 insertions(+), 189 deletions(-)
Signature · 1 line
2.40.1