Skip to content

qemu-nbd: fix regression with qemu-nbd --fork run over ssh

Denis V. Lunev qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 14 repliesIn review
  2. v11 patch 4 repliesSuperseded

Changes in v2 from the cover letter

* added patch 1, necessary to pass fork_process into nbd_client_thread
* tweaked comment in patch 2 a bit
* added patches 3-5 with error handling improvements

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5qemu-nbd: pass structure into nbd_client_thread instead of plain char*qemu-nbd.c+13 -61 reply
2/5qemu-nbd: fix regression with qemu-nbd --fork run over sshqemu-nbd.c+4 -98 replies
3/5qemu-nbd: properly report error on error in dup2() after qemu_daemon()qemu-nbd.c+14 -11 reply
4/5qemu-nbd: properly report error if qemu_daemon() is failedqemu-nbd.c+4 -11 reply
5/5qemu-nbd: handle dup2() error when qemu-nbd finished setup processqemu-nbd.c+12 -21 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric Blake
SeriesR-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] qemu-nbd: fix regression with qemu-nbd --fork run over ssh

Patches 3-5 are not necessary for stable, I believe.

Changes from v1:
* added patch 1, necessary to pass fork_process into nbd_client_thread
* tweaked comment in patch 2 a bit
* added patches 3-5 with error handling improvements

CC Eric Blake <[email protected]>
CC Vladimir Sementsov-Ogievskiy <[email protected]>