Skip to content

migration: Only pass negative values to qemu_file_set_error()

Fabiano Rosas qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2target/arm: Return negative value on power state migration errortarget/arm/machine.c+1 -10 replies
2/2migration: Make it clear that qemu_file_set_error() needs a negative valuemigration/qemu-file.c migration/savevm.c+5 -32 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] migration: Only pass negative values to qemu_file_set_error()

qemu_file_set_error() sets f->last_error, which is later used by functions in qemu-file.c to return the error to callers.

The following functions expect f->last_error to be -errno:

qemu_file_get_error_obj()
qemu_file_get_error()
qemu_fclose()

Make sure qemu_file_set_error() always receives a negative number and document the assumption.

Fabiano Rosas (2):
target/arm: Return negative value on power state migration error
migration: Make it clear that qemu_file_set_error() needs a negative
value

 migration/qemu-file.c | 2 ++
 migration/savevm.c    | 6 +++---
 target/arm/machine.c  | 2 +-
 3 files changed, 6 insertions(+), 4 deletions(-)
Signature · 1 line
2.35.3