Skip to content

s390x: Improve console handling

Janosch Frank kvm linux-s390 1 version NAK

Status from this message: NACK.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyNAK

Changes in v1 from the cover letter

- Switched to \r\n from \n\r
- Removed console clear
- Added truncation logic to maintain 2k limit

Patches in v1

#Subject and filesSizeRepliesApplied
1/2lib: s390x: sclp: Add carriage return to line feedlib/s390x/sclp-console.c+18 -10 replies
2/2lib: s390x: sclp: Add line mode input handlinglib/s390x/sclp-console.c lib/s390x/sclp.h+180 -201 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [kvm-unit-tests PATCH 0/2] s390x: Improve console handling

Console IO is and has been in a state of "works for me". I don't think that will change soon since there's no need for a proper console driver when all we want is the ability to print or read a line at a time.

However since input is only supported on the ASCII console I was forced to use it on the HMC. The HMC generally does not add a \r on a \n so each line doesn't necessarily start at column 0. It's time to finally fix that.

Also, since there are environments that only provide the line-mode console it's time to add line-mode input to properly support them.

rfc -> v1:
- Switched to \r\n from \n\r
- Removed console clear
- Added truncation logic to maintain 2k limit

Janosch Frank (2):
lib: s390x: sclp: Add carriage return to line feed
lib: s390x: sclp: Add line mode input handling

 lib/s390x/sclp-console.c | 193 +++++++++++++++++++++++++++++++++++----
 lib/s390x/sclp.h         |  26 +++++-
 2 files changed, 198 insertions(+), 21 deletions(-)
Signature · 1 line
2.34.1