Skip to content

Fix nohz_full vs cfs bandwidth

Phil Auld lkml 2 versions – Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest1 of 2 patches 9 repliesApplied
  2. v52 patches 9 repliesSuperseded

1 of 2 patches is in this archive. The cover letter announces 2.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
2/2Sched/fair: Block nohz tick_stop when cfs bandwidth in usekernel/sched/core.c kernel/sched/fair.c kernel/sched/features.h +1 more+78 -06 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBen SegallTejun Heo
SeriesR-b R-b A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] Fix nohz_full vs cfs bandwidth

This is v6 of patch 2/2 which is adding code to prevent the tick from being stopped when the single running task has bandwidth limits. Discussions had led to the idea of adding a bit to task_struct to help make this decision.

There was some complexity with doing it in the task which is avoided by using something in the cfs_rq. Looking into that lead me to the hierarchical_quota field in the cfs_bandwith struct. We spend a good deal of effort updating (or trying to, see patch 1/2) that value for the whole task_group tree when a quota is set/changed.

This new version first fixes that value to be meaningful for cgroupv2 and then leverages it to make the decisions about blocking the tick_stop.

Phil Auld (2):
sched, cgroup: Restore meaning to hierarchical_quota Sched/fair: Block nohz tick_stop when cfs bandwidth in use

 kernel/sched/core.c     | 23 ++++++++++++++---
 kernel/sched/fair.c     | 56 ++++++++++++++++++++++++++++++++++++++---
 kernel/sched/features.h |  2 ++
 kernel/sched/sched.h    |  3 ++-
 4 files changed, 76 insertions(+), 8 deletions(-)
Signature · 1 line
2.31.1