Skip to content

remove unused "base-offset" from tree-walk codepath

Junio C Hamano git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tree-walk: lose base_offset that is never used in tree_entry_interestingbuiltin/grep.c list-objects.c tree-diff.c +3 more+8 -70 replies
2/2tree-walk: drop unused base_offset from do_match()tree-walk.c+16 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] remove unused "base-offset" from tree-walk codepath

Here are a few bonus patches I came up with while working on the "hmm, attr magic does not seem to work with pathspec patterns?" topic to remove a parameter that is passed around without getting any value other than 0 (hence nobody knows if the code is correct when the parameter is set to non-zero).

It turned out that they do not interact with the main topic in any way, so I made it into a separate and indenendent series.

Junio C Hamano (2):
tree-walk: lose base_offset that is never used in
tree_entry_interesting
tree-walk: drop unused base_offset from do_match()

 builtin/grep.c |  2 +-
 list-objects.c |  2 +-
 tree-diff.c    |  2 +-
 tree-walk.c    | 36 ++++++++++++++++++------------------
 tree-walk.h    |  2 +-
 tree.c         |  2 +-
 6 files changed, 23 insertions(+), 23 deletions(-)
Signature · 1 line
2.41.0-318-g061c58647e