Skip to content

ice: implement cross timestamping for E823

Jacob Keller intel-wired-lan 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v14 patches 0 repliesSuperseded

Changes since v2 from the cover letter

* use ice_ptp_src_cmd() instead of ice_ptp_clean_cmd() in the cross timestamping function.
* drop the patch introducing ice_ptp_clean_cmd() as this is superseded by the correct fix that resolves the stale commands issue for both the main timer and the PHY port timers.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ice: prefix clock timer command enumeration values with ICE_PTPdrivers/net/ethernet/intel/ice/ice_ptp_hw.c drivers/net/ethernet/intel/ice/ice_ptp_hw.h+50 -501 reply
2/3ice: retry acquiring hardware semaphore during cross-timestamp requestdrivers/net/ethernet/intel/ice/ice_ptp.c+15 -71 reply
3/3ice: Support cross-timestamping for E823 devicesdrivers/net/ethernet/intel/ice/ice_ptp.c drivers/net/ethernet/intel/ice/ice_ptp_hw.c drivers/net/ethernet/intel/ice/ice_ptp_hw.h+22 -111 reply

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchPucha Himasekhar Reddy
1/3T-b
2/3T-b
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-wired-lan] [PATCH iwl-next v2 0/3] ice: implement cross timestamping for E823

This series fixes and enables cross timestamping for the E823 line of products. This product line is very similar to E822 devices, but has a new requirement for cross timestamping to function.

First, Sergey has a patch to cleanup the timer commands to include ICE_PTP_ prefix.

Second, Karol has a fix to ensure that we retry acquiring the hardware semaphore a few times before giving up when requesting a cross timestamp.

Finally, I implement the E823 cross timestamping, fixing an issue where the timer command register was not programmed as expected. Without the READ_TIME bits being set, E823 hardware will not capture the device time.

Changes since v2:
* use ice_ptp_src_cmd() instead of ice_ptp_clean_cmd() in the cross timestamping function.
* drop the patch introducing ice_ptp_clean_cmd() as this is superseded by the correct fix that resolves the stale commands issue for both the main timer and the PHY port timers.

Jacob Keller (1):
ice: Support cross-timestamping for E823 devices

Karol Kolacinski (1):
ice: retry acquiring hardware semaphore during cross-timestamp request

Sergey Temerkhanov (1):
ice: prefix clock timer command enumeration values with ICE_PTP

 drivers/net/ethernet/intel/ice/ice_ptp.c    | 51 ++++++++----
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 92 ++++++++++-----------
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 12 +--
 3 files changed, 87 insertions(+), 68 deletions(-)

base-commit: 627821f47a1511824efe734a786cbf1454685c81

Signature · 6 lines
2.41.0.1.g9857a21e0017.dirty

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan