Improve async iomap DIO performance
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest8 patches 5 repliesIn review
- v59 patches 10 repliesSuperseded
- v48 patches 29 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 6 patches | 10 replies | Superseded | |
| v2 | 5 patches | 4 replies | Superseded | |
| v1 | 5 patches | 4 replies | Superseded |
Changes in v6 from the cover letter
- Drop the polled patch, it's not needed anymore
- Change the "inline is safe" logic based on Dave's suggestions
- Gate HIPRI on INLINE_COMP|CALLER_COMP, so polled IO follows the same rules as inline/deferred completions.
- INLINE_COMP is purely for reads, writes can user CALLER_COMP to avoid a workqueue punt. This is necessary as we need to invalidate pages on write completions, and if we race with a buffered reader or writer on the file.
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | iomap: cleanup up iomap_dio_bio_end_io()fs/ | +31 | 0 replies | |
| 2/8 | iomap: use an unsigned type for IOMAP_DIO_* definesfs/ | +4 | 0 replies | |
| 3/8 | iomap: treat a write through cache the same as FUAfs/ | +20 | 0 replies | |
| 4/8 | iomap: only set iocb->private for polled biofs/ | +5 | 0 replies | |
| 5/8 | iomap: add IOMAP_DIO_INLINE_COMPfs/ | +8 | 0 replies | |
| 6/8 | fs: add IOCB flags related to passing back dio completionsinclude/ | +33 | 0 replies | |
| 7/8 | io_uring/rw: add write support for IOCB_DIO_CALLER_COMPio_uring/ | +23 | 0 replies | |
| 8/8 | iomap: support IOCB_DIO_CALLER_COMPfs/ | +60 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Darrick J. Wong | Christoph Hellwig | Dave Chinner |
|---|---|---|---|
| Series | R-b | ||
| 1/8 | R-b | R-b | |
| 2/8 | R-b | R-b | |
| 3/8 | R-b | R-b | |
| 4/8 | R-b | R-b | |
| 5/8 | R-b | R-b | |
| 6/8 | R-b | R-b | |
| 7/8 | R-b | R-b | |
| 8/8 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCHSET v6 0/8] Improve async iomap DIO performance
Hi,
Hi,
This patchset improves async iomap DIO performance, for XFS and ext4. For full details on this patchset, see the v4 posting:
https://lore.kernel.org/io-uring/[email protected]/
fs/iomap/direct-io.c | 163 ++++++++++++++++++++++++++++++++----------- include/linux/fs.h | 35 +++++++++- io_uring/rw.c | 26 ++++++- 3 files changed, 179 insertions(+), 45 deletions(-)
Can also be found here:
https://git.kernel.dk/cgit/linux/log/?h=xfs-async-dio.6
No change in performance since last time, and passes my testing without complaints.
Changes in v6:
- Drop the polled patch, it's not needed anymore
- Change the "inline is safe" logic based on Dave's suggestions
- Gate HIPRI on INLINE_COMP|CALLER_COMP, so polled IO follows the same rules as inline/deferred completions.
- INLINE_COMP is purely for reads, writes can user CALLER_COMP to avoid a workqueue punt. This is necessary as we need to invalidate pages on write completions, and if we race with a buffered reader or writer on the file.
Signature · 1 line
Jens Axboe