Skip to content

blk-mq: fix wrong queue mapping for kdump kernel

Ming Lei kexec linux-block linux-nvme linux-scsi linuxppc-dev lkml oe-lkp virtualization 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 9 repliesIn review
  2. v29 patches 15 repliesSuperseded
  3. v18 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- cover more drivers
- clean up blk-mq a bit, as suggested by Christoph

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14blk-mq: add blk_mq_max_nr_hw_queues()block/blk-mq.c include/linux/blk-mq.h+17 -08 replies
2/14nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queuesdrivers/nvme/host/pci.c+1 -10 replies
3/14ublk: limit max allowed nr_hw_queuesdrivers/block/ublk_drv.c+1 -10 replies
4/14virtio-blk: limit max allowed submit queuesdrivers/block/virtio_blk.c+2 -11 reply
5/14scsi: core: add helper of scsi_max_nr_hw_queues()include/scsi/scsi_host.h+5 -00 replies
6/14scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectorsdrivers/scsi/lpfc/lpfc_init.c+2 -00 replies
7/14scsi: mpi3mr: take blk_mq_max_nr_hw_queues() into account for calculating io vectorsdrivers/scsi/mpi3mr/mpi3mr_fw.c+3 -00 replies
8/14scsi: megaraid: take blk_mq_max_nr_hw_queues() into account for calculating io vectorsdrivers/scsi/megaraid/megaraid_sas_base.c+5 -10 replies
9/14scsi: mpt3sas: take blk_mq_max_nr_hw_queues() into account for calculating io vectorsdrivers/scsi/mpt3sas/mpt3sas_base.c+2 -20 replies
10/14scsi: pm8001: take blk_mq_max_nr_hw_queues() into account for calculating io vectorsdrivers/scsi/pm8001/pm8001_init.c+3 -10 replies
11/14scsi: hisi: take blk_mq_max_nr_hw_queues() into account for calculating io vectorsdrivers/scsi/hisi_sas/hisi_sas_v3_hw.c+3 -00 replies
12/14scsi: ufs: limit max allowed nr_hw_queuesdrivers/ufs/core/ufs-mcq.c+1 -10 replies
13/14scsi: storvsc: limit max allowed nr_hw_queuesdrivers/scsi/storvsc_drv.c+3 -00 replies
14/14blk-mq: add helpers for treating kdump kernelblock/blk-mq.c+27 -120 replies

Reviews trailers per patch

3 of 14 patches have a Reviewed-by or Acked-by.

PatchJustin TeeJack WangMichael S. Tsirkin
1/14
2/14
3/14
4/14A-b
5/14
6/14R-b
7/14
8/14
9/14
10/14A-b
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH V3 0/14] blk-mq: fix wrong queue mapping for kdump kernel

Hi,

Fix wrong queue mapping for kdump kernel since blk-mq updates nr_hw_queues to 1, so driver and blk-mq may have different queue topo.

V3:
- cover more drivers
- clean up blk-mq a bit, as suggested by Christoph

V2:
- add helper of scsi_max_nr_hw_queues() for avoiding potential build failure because scsi driver often doesn't deal with blk-mq directly
- apply scsi_max_nr_hw_queues() for all scsi changes
- move lpfc's change into managed irq code path

Ming Lei (14):
blk-mq: add blk_mq_max_nr_hw_queues()
nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues
ublk: limit max allowed nr_hw_queues
virtio-blk: limit max allowed submit queues
scsi: core: add helper of scsi_max_nr_hw_queues()
scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectors
scsi: mpi3mr: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: megaraid: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: mpt3sas: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: pm8001: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: hisi: take blk_mq_max_nr_hw_queues() into account for
calculating io vectors
scsi: ufs: limit max allowed nr_hw_queues
scsi: storvsc: limit max allowed nr_hw_queues
blk-mq: add helpers for treating kdump kernel

 block/blk-mq.c                            | 55 ++++++++++++++++++-----
 drivers/block/ublk_drv.c                  |  2 +-
 drivers/block/virtio_blk.c                |  3 +-
 drivers/nvme/host/pci.c                   |  2 +-
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c    |  3 ++
 drivers/scsi/lpfc/lpfc_init.c             |  2 +
 drivers/scsi/megaraid/megaraid_sas_base.c |  6 ++-
 drivers/scsi/mpi3mr/mpi3mr_fw.c           |  3 ++
 drivers/scsi/mpt3sas/mpt3sas_base.c       |  4 +-
 drivers/scsi/pm8001/pm8001_init.c         |  4 +-
 drivers/scsi/storvsc_drv.c                |  3 ++
 drivers/ufs/core/ufs-mcq.c                |  2 +-
 include/linux/blk-mq.h                    |  1 +
 include/scsi/scsi_host.h                  |  5 +++
 14 files changed, 75 insertions(+), 20 deletions(-)
Signature · 1 line
2.40.1