Skip to content

#if defined(ISP2401) removal to make driver generic

Kate Hsuan linux-media linux-staging 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11media: atomisp: ia_css_debug: Removed debug codes for dumping statusdrivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_public.h drivers/staging/media/atomisp/pci/isp2400_input_system_local.h +6 more+1 -4810 replies
2/11media: atomisp: Make two individual enum to define the MIPI formatdrivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c drivers/staging/media/atomisp/pci/isp2400_input_system_local.h drivers/staging/media/atomisp/pci/isp2400_input_system_public.h +3 more+224 -1650 replies
3/11media: atomisp: Included both input system headersdrivers/staging/media/atomisp/pci/input_system_local.h drivers/staging/media/atomisp/pci/input_system_private.h drivers/staging/media/atomisp/pci/input_system_public.h +5 more+15 -260 replies
4/11media: atomisp: css_2401_system: Remove #ifdef ISP2401 to make the driver genericdrivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_local.h drivers/staging/media/atomisp/pci/css_2401_system/host/isys_irq_private.h drivers/staging/media/atomisp/pci/css_2401_system/isys_irq_global.h+0 -70 replies
5/11media: atomisp: isys: Removed #if defined(ISP2401) to make driver genericdrivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_dma_public.h drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isys_irq_public.h drivers/staging/media/atomisp/pci/hive_isp_css_include/isys_irq.h+0 -60 replies
6/11media: atomisp: hive_isp_css_common: Removed #if defined(ISP2401) to make driver genericdrivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c+0 -20 replies
7/11media: atomisp: pipeline: Removed #if defined(ISP2401) to make driver genericdrivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c+0 -40 replies
8/11media: atomisp: ifmtr: Removed #if defined(ISP2401) to make driver genericdrivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_formatter.c drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c drivers/staging/media/atomisp/pci/sh_css_sp.c +1 more+0 -80 replies
9/11media: atomisp: Compile the object codes for a generic driverdrivers/staging/media/atomisp/Makefile drivers/staging/media/atomisp/pci/runtime/isys/interface/ia_css_isys.h drivers/staging/media/atomisp/pci/runtime/isys/interface/ia_css_isys_comm.h +4 more+3 -280 replies
10/11media: atomisp: rx: Removed #if defined(ISP2401) to make driver genericdrivers/staging/media/atomisp/pci/runtime/isys/src/rx.c+4 -150 replies
11/11media: atomisp: isys_init: Initiate atomisp in a generic mannerdrivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c+15 -160 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans de Goede
SeriesR-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] #if defined(ISP2401) removal to make driver generic

This patch set is to remove #if defined(ISP2401) to make the driver generic. We focused on removing the #if defined(ISP2401) in isys and necessary files related to it.

The changes include:
1. Removed #if defined(ISP2401) in isys and related directories.
2. Removed the debug codes for dumping status.
3. Made two individual enum to define the MIPI format for both types of atomisp.
4. The input system code should include both input system (ISP2400 and ISP2401) headers since a generic driver should cover all types of devcices.
5. The initialization codes of the input system was modified to initiate atomisp input system in a generic manner.

Kate Hsuan (11):
media: atomisp: ia_css_debug: Removed debug codes for dumping status
media: atomisp: Make two individual enum to define the MIPI format
media: atomisp: Included both input system headers
media: atomisp: css_2401_system: Remove #ifdef ISP2401 to make the
driver generic
media: atomisp: isys: Removed #if defined(ISP2401) to make driver
generic
media: atomisp: hive_isp_css_common: Removed #if defined(ISP2401) to
make driver generic
media: atomisp: pipeline: Removed #if defined(ISP2401) to make driver
generic
media: atomisp: ifmtr: Removed #if defined(ISP2401) to make driver
generic
media: atomisp: Compile the object codes for a generic driver
media: atomisp: rx: Removed #if defined(ISP2401) to make driver
generic
media: atomisp: isys_init: Initiate atomisp in a generic manner

 drivers/staging/media/atomisp/Makefile        |  12 +-
 .../pci/css_2401_system/host/isys_irq_local.h |   3 -
 .../css_2401_system/host/isys_irq_private.h   |   2 -
 .../pci/css_2401_system/isys_irq_global.h     |   2 -
 .../host/input_formatter.c                    |   2 -
 .../hive_isp_css_common/host/input_system.c   |  75 -----
 .../host/isys_dma_public.h                    |   2 -
 .../host/isys_irq_public.h                    |   2 -
 .../hive_isp_css_include/host/isys_public.h   |  19 --
 .../pci/hive_isp_css_include/isys_irq.h       |   2 -
 .../media/atomisp/pci/input_system_local.h    |   7 +-
 .../media/atomisp/pci/input_system_private.h  |   7 +-
 .../media/atomisp/pci/input_system_public.h   |   4 +-
 .../atomisp/pci/isp2400_input_system_local.h  |  89 +++---
 .../pci/isp2400_input_system_private.h        |   4 +-
 .../atomisp/pci/isp2400_input_system_public.h |  13 +-
 .../atomisp/pci/isp2401_input_system_local.h  |  88 +++---
 .../pci/isp2401_input_system_private.h        | 112 +-------
 .../runtime/debug/interface/ia_css_debug.h    |   6 -
 .../pci/runtime/debug/src/ia_css_debug.c      | 256 ------------------
 .../atomisp/pci/runtime/ifmtr/src/ifmtr.c     |   2 -
 .../pci/runtime/isys/interface/ia_css_isys.h  |   9 +-
 .../runtime/isys/interface/ia_css_isys_comm.h |   2 -
 .../pci/runtime/isys/src/csi_rx_rmgr.c        |   2 -
 .../pci/runtime/isys/src/isys_dma_rmgr.c      |   2 -
 .../atomisp/pci/runtime/isys/src/isys_init.c  |  31 +--
 .../runtime/isys/src/isys_stream2mmio_rmgr.c  |   2 -
 .../media/atomisp/pci/runtime/isys/src/rx.c   | 227 ++++++++++------
 .../pci/runtime/isys/src/virtual_isys.c       |   8 +-
 .../pipeline/interface/ia_css_pipeline.h      |   2 -
 .../pci/runtime/pipeline/src/pipeline.c       |   2 -
 drivers/staging/media/atomisp/pci/sh_css.c    |   2 -
 drivers/staging/media/atomisp/pci/sh_css_sp.c |   2 -
 drivers/staging/media/atomisp/pci/sh_css_sp.h |   2 -
 34 files changed, 253 insertions(+), 749 deletions(-)
Signature · 1 line
2.41.0