Skip to content

fs: dlm: workarounds and cancellation

Alexander Aring cluster-devel stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 0 repliesNew

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fs: dlm: ignore DLM_PLOCK_FL_CLOSE flag resultsfs/dlm/plock.c+8 -00 replies
2/3fs: dlm: introduce DLM_PLOCK_FL_NO_REPLY flagfs/dlm/plock.c include/uapi/linux/dlm_plock.h+11 -60 replies
3/3fs: dlm: allow to F_SETLKW getting interruptedfs/dlm/plock.c include/uapi/linux/dlm_plock.h+66 -260 replies
3/3fs: dlm: allow to F_SETLKW getting interrupted+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Cluster-devel] [PATCHv2 v6.5-rc1 0/3] fs: dlm: workarounds and cancellation

Hi,

This patch-series trying to avoid issues when plock ops with DLM_PLOCK_FL_CLOSE flag is set sends a reply back which should never be the case. This problem getting more serious when introducing a new plock op and an answer was not expected as

I changed in v2 to check on DLM_PLOCK_FL_CLOSE flag for stable as this can also being used to fix the potential issue for older kernels and it does not change the UAPI. For newer user space applications the new flag DLM_PLOCK_FL_NO_REPLY will tell the user space application to never send an result back, it will handle this filter earlier in user space. For older user space software we will filter the result in ther kernel.

This requires the behaviour that the flags are the same for the request and the reply which is the case for dlm_controld.

Also fix the wrapped string and don't spam the user ignoring replies.

- Alex

Alexander Aring (3):
fs: dlm: ignore DLM_PLOCK_FL_CLOSE flag results
fs: dlm: introduce DLM_PLOCK_FL_NO_REPLY flag
fs: dlm: allow to F_SETLKW getting interrupted

 fs/dlm/plock.c                 | 107 ++++++++++++++++++++++++---------
 include/uapi/linux/dlm_plock.h |   2 +
 2 files changed, 81 insertions(+), 28 deletions(-)
Signature · 1 line
2.31.1