Skip to content

add input flags and "no-dns"/"json" flags

Thomas Haller netfilter-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 1 replyIn review
  2. v46 patches 17 repliesSuperseded
  3. v34 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v23 patches8 repliesSuperseded

Changes in v5 from the cover letter

- rename python API {set,get}_input() to {set,get}_input_flags() and update commit message. Other 5 out of 6 patches are unchanged (except adding Reviewed-by tag from Phil).

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6src: add input flags for nft_ctxdoc/libnftables.adoc include/nftables.h include/nftables/libnftables.h +2 more+42 -00 replies
2/6src: add input flag NFT_CTX_INPUT_NO_DNS to avoid blockingdoc/libnftables.adoc include/datatype.h include/nftables.h +3 more+67 -310 replies
3/6src: add input flag NFT_CTX_INPUT_JSON to enable JSON parsingdoc/libnftables.adoc include/nftables.h include/nftables/libnftables.h +1 more+16 -30 replies
4/6py: fix exception during cleanup of half-initialized Nftablespy/src/nftables.py+5 -10 replies
5/6py: extract flags helper functions for set_debug()/get_debug()py/src/nftables.py+31 -210 replies
6/6py: add Nftables.{get,set}_input_flags() APIpy/src/nftables.py+43 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchPhil Sutter
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [nft PATCH v5 0/6] add input flags and "no-dns"/"json" flags

Changes since v4:

- rename python API {set,get}_input() to {set,get}_input_flags() and update commit message. Other 5 out of 6 patches are unchanged (except adding Reviewed-by tag from Phil).

Changes since v3:

- set-input() now returns the old value (both for Python and C API)
- python: API follows the style of existing set_debug()/get_debug() methods.
- nft_input_no_dns()/nft_input_json() helper functions added and used.
- python: new patch to better handle exception while creating Nftables instance.

Thomas Haller (6):
src: add input flags for nft_ctx
src: add input flag NFT_CTX_INPUT_NO_DNS to avoid blocking
src: add input flag NFT_CTX_INPUT_JSON to enable JSON parsing
py: fix exception during cleanup of half-initialized Nftables
py: extract flags helper functions for set_debug()/get_debug()
py: add Nftables.{get,set}_input_flags() API

 doc/libnftables.adoc           |  30 +++++++++-
 include/datatype.h             |   1 +
 include/nftables.h             |  15 +++++
 include/nftables/libnftables.h |   8 +++
 py/src/nftables.py             | 101 ++++++++++++++++++++++++++-------
 src/datatype.c                 |  68 +++++++++++++---------
 src/evaluate.c                 |  10 +++-
 src/libnftables.c              |  20 ++++++-
 src/libnftables.map            |   5 ++
 9 files changed, 203 insertions(+), 55 deletions(-)
Signature · 1 line
2.41.0