Skip to content

leds: turris-omnia: updates

Marek Behún linux-leds 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyApplied
  2. v36 patches 20 repliesApplied
  3. v23 patches 6 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4leds: turris-omnia: do not use SMBUS callsdrivers/leds/leds-turris-omnia.c+43 -120 replies
2/4leds: turris-omnia: make set_brightness() more efficientdrivers/leds/leds-turris-omnia.c+78 -180 replies
3/4leds: turris-omnia: support HW controlled mode via private triggerdrivers/leds/Kconfig drivers/leds/leds-turris-omnia.c+91 -80 replies
4/4leds: turris-omnia: add support for enabling/disabling HW gamma correctionDocumentation/ABI/testing/sysfs-class-led-driver-turris-omnia drivers/leds/leds-turris-omnia.c+134 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] leds: turris-omnia: updates

Hello Lee,

I am sending version 4 of Turris Omnia's LED controller updates. I tried to address the issues you mentioned:
- I made the omnia_cmd_read_raw() function to return the number of read bytes on success
- I have renamed omnia_cmd_read() to omnia_cmd_read_u8() since it always reads one byte. The function returns the read byte on success and a negative errno on failure
- accordingly, I have renamed omnia_cmd_write() to omnia_cmd_write_u8(), and made it so that it returns the number of written bytes on success
- the newly added comments now start with a capital letter

Marek

Marek Behún (4):
leds: turris-omnia: do not use SMBUS calls
leds: turris-omnia: make set_brightness() more efficient
leds: turris-omnia: support HW controlled mode via private trigger
leds: turris-omnia: add support for enabling/disabling HW gamma
correction

 .../sysfs-class-led-driver-turris-omnia       |  14 +
 drivers/leds/Kconfig                          |   1 +
 drivers/leds/leds-turris-omnia.c              | 352 ++++++++++++++++--
 3 files changed, 329 insertions(+), 38 deletions(-)
Signature · 1 line
2.41.0