Skip to content

can: gs_usb-cleanups: various clenaups

Marc Kleine-Budde linux-can 1 version New

Get series with b4
b4 am [email protected] change-id 20230717-gs_usb-cleanups-e7ff177ef040

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11can: gs_usb: remove leading space from goto labelsdrivers/net/can/usb/gs_usb.c+6 -60 replies
2/11can: gs_usb: gs_usb_probe(): align block commentdrivers/net/can/usb/gs_usb.c+2 -20 replies
3/11can: gs_usb: gs_usb_set_timestamp(): remove return statements form void functiondrivers/net/can/usb/gs_usb.c+0 -20 replies
4/11can: gs_usb: uniformly use "parent" as variable name for struct gs_usbdrivers/net/can/usb/gs_usb.c+31 -310 replies
5/11can: gs_usb: gs_usb_receive_bulk_callback(): make use of netdevdrivers/net/can/usb/gs_usb.c+2 -20 replies
6/11can: gs_usb: gs_usb_receive_bulk_callback(): make use of statsdrivers/net/can/usb/gs_usb.c+5 -50 replies
7/11can: gs_usb: gs_usb_receive_bulk_callback(): count RX overflow errors also in case of OOMdrivers/net/can/usb/gs_usb.c+3 -20 replies
8/11can: gs_usb: gs_can_start_xmit(), gs_can_open(): clean up printouts in error pathdrivers/net/can/usb/gs_usb.c+3 -60 replies
9/11cam: gs_usb: gs_can_close(): don't complain about failed device reset during ndo_stopdrivers/net/can/usb/gs_usb.c+1 -30 replies
10/11can: gs_usb: gs_destroy_candev(): remove not needed usb_kill_anchored_urbs()drivers/net/can/usb/gs_usb.c+0 -10 replies
11/11can: gs_usb: gs_usb_disconnect(): remove not needed usb_kill_anchored_urbs()drivers/net/can/usb/gs_usb.c+0 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] can: gs_usb-cleanups: various clenaups

This is a cleanup series of the gs_usb driver. Align the driver more to the kernel coding style, make use of locally defined variables, clean up printouts in various error paths, remove some not needed usb_kill_anchored_urbs() from the shut down paths.

This series depends on the PR
https://lore.kernel.org/all/[email protected]
and the patch
https://lore.kernel.org/all/[email protected]

regards,
Marc

---
Marc Kleine-Budde (11):
can: gs_usb: remove leading space from goto labels
can: gs_usb: gs_usb_probe(): align block comment
can: gs_usb: gs_usb_set_timestamp(): remove return statements form void function
can: gs_usb: uniformly use "parent" as variable name for struct gs_usb
can: gs_usb: gs_usb_receive_bulk_callback(): make use of netdev
can: gs_usb: gs_usb_receive_bulk_callback(): make use of stats
can: gs_usb: gs_usb_receive_bulk_callback(): count RX overflow errors also in case of OOM
can: gs_usb: gs_can_start_xmit(), gs_can_open(): clean up printouts in error path
cam: gs_usb: gs_can_close(): don't complain about failed device reset during ndo_stop
can: gs_usb: gs_destroy_candev(): remove not needed usb_kill_anchored_urbs()
can: gs_usb: gs_usb_disconnect(): remove not needed usb_kill_anchored_urbs()

 drivers/net/can/usb/gs_usb.c | 112 ++++++++++++++++++++-----------------------
 1 file changed, 52 insertions(+), 60 deletions(-)

---
base-commit: 13561659276838b7f1ab7214b28fba51795bbdcd
change-id: 20230717-gs_usb-cleanups-e7ff177ef040

Best regards,

Signature · 1 line
Marc Kleine-Budde <[email protected]>