Skip to content

hwmon: (oxp-sensors) Refactor probe() and init() and remove devm_add_groups()

Joaquín Ignacio Aramendía linux-hwmon lkml 2 versions Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesApplied
  2. v13 patches 5 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2hwmon: (oxp-sensors) Move tt_toggle attribute to dev_groupsdrivers/hwmon/oxp-sensors.c+24 -142 replies
2/2hwmon: (oxp-sensors) Move board detection to the init functiondrivers/hwmon/oxp-sensors.c+15 -142 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGreg Kroah-Hartman
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] hwmon: (oxp-sensors) Refactor probe() and init() and remove devm_add_groups()

Remove the use of devm_add_groups() in favour of dev_groups in platform driver structure. This will allow for removal of the function as it was intended in Greg's email[1].

Also move board detection to the init() instead of probe() function so we don't instantiate the driver if the detection fails.

V2 drops the 3rd patch that removed the probe() function.

[1] Link: https://lore.kernel.org/linux-hwmon/[email protected]/

Joaquín Ignacio Aramendía (2):
hwmon: (oxp-sensors) Move tt_toggle attribute to dev_groups
hwmon: (oxp-sensors) Move board detection to the init function

 drivers/hwmon/oxp-sensors.c | 67 +++++++++++++++++++++----------------
 1 file changed, 39 insertions(+), 28 deletions(-)
Signature · 1 line
2.41.0