Skip to content

Make PDX compression optional

Alejandro Vallejo xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 15 repliesIn review
  2. v25 patches 23 repliesSuperseded
  3. v18 patches 25 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mm: Factor out the pdx compression logic in ma/va convertersxen/arch/arm/include/asm/mm.h xen/arch/x86/include/asm/x86_64/page.h xen/include/xen/pdx.h+38 -180 replies
2/4mm/pdx: Standardize region validation wrt pdx compressionxen/arch/x86/x86_64/mm.c xen/common/efi/boot.c xen/common/pdx.c +1 more+31 -70 replies
3/4pdx: Reorder pdx.[ch]xen/common/pdx.c xen/include/xen/pdx.h+59 -580 replies
4/4pdx: Add CONFIG_PDX_COMPRESSION as a common Kconfig optionxen/arch/arm/Kconfig xen/arch/x86/Kconfig xen/arch/x86/domain.c +4 more+71 -198 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJulien Grall
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] Make PDX compression optional

Currently there's a CONFIG_HAS_PDX Kconfig option, but it's impossible to disable it because the whole codebase performs unconditional compression/decompression operations on addresses. This has the unfortunate side effect that systems without a need for compression still have to pay the performance impact of juggling bits on every pfn<->pdx conversion (this requires reading several global variables). This series attempts to:

* Leave the state of pdx and pdx compression documented
* Factor out compression so it _can_ be removed through Kconfig
* Make it so compression is disabled on x86 and enabled on both Aarch32 and Aarch64 by default.

Series summary:

Patch 1 Moves hard-coded compression-related logic to helper functions Patch 2 Refactors all instances of regions being validated for pdx
compression conformance so it's done through a helper
Patch 3 Non-functional reorder in order to simplify the patch 8 diff Patch 4 Adds new Kconfig option to compile out PDX compression and removes
the old CONFIG_HAS_PDX, as it was non removable

Already committed:

v1/patch 1 documents the current general understanding of the pdx concept and
pdx compression in particular
v1/patch 3 Marks the pdx compression globals as ro_after_init v2/patch 1 Documents the differences between arm32 and arm64 directmaps

Alejandro Vallejo (4):
mm: Factor out the pdx compression logic in ma/va converters mm/pdx: Standardize region validation wrt pdx compression
pdx: Reorder pdx.[ch]
pdx: Add CONFIG_PDX_COMPRESSION as a common Kconfig option

 xen/arch/arm/Kconfig                   |   1 -
 xen/arch/arm/include/asm/mm.h          |   3 +-
 xen/arch/x86/Kconfig                   |   1 -
 xen/arch/x86/domain.c                  |  19 ++--
 xen/arch/x86/include/asm/x86_64/page.h |  28 +++---
 xen/arch/x86/x86_64/mm.c               |   6 +-
 xen/common/Kconfig                     |  13 ++-
 xen/common/Makefile                    |   2 +-
 xen/common/efi/boot.c                  |  13 ++-
 xen/common/pdx.c                       |  76 +++++++++------
 xen/include/xen/pdx.h                  | 127 +++++++++++++++++++------
 11 files changed, 193 insertions(+), 96 deletions(-)
Signature · 1 line
2.34.1