Skip to content

Improve performance for BLK_MQ_F_BLOCKING drivers

Bart Van Assche linux-block 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesApplied
  2. v23 patches 5 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Improved the descriptions of patches 1/3 and 2/3.
- Added a comment in patch 2/3.
- In patch 3/3, included a change for blk_execute_rq_nowait() since I noticed that this function may be called from a context where it is not allowed to sleep (nvme_uring_cmd_io() for NVMe over TCP).

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3scsi: Inline scsi_kick_queue()drivers/scsi/scsi_lib.c+2 -71 reply
2/3scsi: Remove a blk_mq_run_hw_queues() calldrivers/scsi/scsi_lib.c+1 -11 reply
3/3block: Improve performance for BLK_MQ_F_BLOCKING driversblock/blk-mq.c drivers/scsi/scsi_lib.c+12 -70 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigMartin K. Petersen
1/3R-b R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Improve performance for BLK_MQ_F_BLOCKING drivers

Hi Jens,

Request queues are run asynchronously if BLK_MQ_F_BLOCKING has been set. This results in suboptimal performance. This patch series improves performance if BLK_MQ_F_BLOCKING has been set by running request queues synchronously whenever possible.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v2:
- Improved the descriptions of patches 1/3 and 2/3.
- Added a comment in patch 2/3.
- In patch 3/3, included a change for blk_execute_rq_nowait() since I noticed that this function may be called from a context where it is not allowed to sleep (nvme_uring_cmd_io() for NVMe over TCP).

Changes compared to v1:
- Fixed support for the combination BLK_MQ_F_BLOCKING + BLIST_SINGLELUN.

Bart Van Assche (3):
scsi: Inline scsi_kick_queue()
scsi: Remove a blk_mq_run_hw_queues() call
block: Improve performance for BLK_MQ_F_BLOCKING drivers

 block/blk-mq.c          | 17 +++++++++++------
 drivers/scsi/scsi_lib.c | 12 ++++--------
 2 files changed, 15 insertions(+), 14 deletions(-)