Skip to content

target/mips: Avoid shift by negative number in page_table_walk_refill()

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 3 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2target/mips: Pass directory/leaf shift values to walk_directory()target/mips/tcg/sysemu/tlb_helper.c+8 -101 reply
2/2target/mips: Avoid shift by negative number in page_table_walk_refill()target/mips/tcg/sysemu/tlb_helper.c+17 -152 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH for-8.1 v2 0/2] target/mips: Avoid shift by negative number in page_table_walk_refill()

This is a respin of Peter's patch, but
- pass already-evaluated values to walk_directory() instead of an assert(),
- check 'ptew > 1' instead of directory/leaf_shift == -1,
- use unsigned type

Since v1: walk_directory() doesn't have to rely on the to sanitize
the input values.

Peter, if you don't see this as an improvement I'll take your original patch.

Regards,

Phil.

Supersedes: <[email protected]>

Philippe Mathieu-Daudé (2):
target/mips: Pass directory/leaf shift values to walk_directory() target/mips: Avoid shift by negative number in
page_table_walk_refill()

 target/mips/tcg/sysemu/tlb_helper.c | 48 ++++++++++++++---------------
 1 file changed, 24 insertions(+), 24 deletions(-)
Signature · 1 line
2.38.1