Skip to content

x86/ioapic: fix edge triggered interrupt migration

Roger Pau Monne xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesIn review
  2. v25 patches 10 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86/ioapic: add a raw field to RTE structxen/arch/x86/include/asm/io_apic.h xen/arch/x86/io_apic.c xen/drivers/passthrough/amd/iommu_intr.c +1 more+35 -320 replies
2/4x86/ioapic: RTE modifications must use ioapic_write_entryxen/arch/x86/include/asm/io_apic.h xen/arch/x86/io_apic.c xen/drivers/passthrough/amd/iommu_intr.c+25 -321 reply
3/4iommu/vtd: rename io_apic_read_remap_rte() local variablexen/drivers/passthrough/vtd/intremap.c+4 -41 reply
4/4x86/iommu: pass full IO-APIC RTE for remapping table updatexen/arch/x86/include/asm/iommu.h xen/arch/x86/io_apic.c xen/drivers/passthrough/amd/iommu.h +5 more+86 -1696 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJan BeulichKevin Tian
1/4A-b
2/4R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] x86/ioapic: fix edge triggered interrupt migration

Hello,

Following series attempts to solve the issue with IO-APIC edge triggered interrupts seeing an inconsistent IRTE when injected while being migrated.

It's been simplified a bit from the original RFC, and does make the logic in the IOMMU RTE update handlers cleaner, as those get passed the full RTE.

When not using interrupt remapping the logic is left as-is. One further change would be to mask edge triggered interrupts, as destination and vector cannot be changed atomically when dealing with plain IO-APIC RTEs.

The previously final patch to switch AMD IOMMU to use atomic RTE updates has been drop pending feedback from AMD on whether that approach is suitable.

Thanks, Roger.

Roger Pau Monne (4):
x86/ioapic: add a raw field to RTE struct x86/ioapic: RTE modifications must use ioapic_write_entry iommu/vtd: rename io_apic_read_remap_rte() local variable x86/iommu: pass full IO-APIC RTE for remapping table update

 xen/arch/x86/include/asm/io_apic.h       |  65 ++++++-----
 xen/arch/x86/include/asm/iommu.h         |   3 +-
 xen/arch/x86/io_apic.c                   |  46 ++++----
 xen/drivers/passthrough/amd/iommu.h      |   2 +-
 xen/drivers/passthrough/amd/iommu_intr.c | 106 ++---------------
 xen/drivers/passthrough/vtd/extern.h     |   2 +-
 xen/drivers/passthrough/vtd/intremap.c   | 140 +++++++++++------------
 xen/drivers/passthrough/x86/iommu.c      |   4 +-
 xen/include/xen/iommu.h                  |   3 +-
 9 files changed, 142 insertions(+), 229 deletions(-)
Signature · 1 line
2.41.0