Skip to content

ext4: fix some ext4_lblk_t overflow issues

Baokun Li linux-ext4 lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 8 repliesApplied
  2. v14 patches 13 repliesSuperseded

Changes in v2 from the cover letter

* Rename fex_end() and pa_end() to extent_logical_end() and pa_logical_end() to make the code more readable.
* Refactor the logic for adjusting the best extent in ext4_mb_new_inode_pa() to simplify the code and remove redundant parameter for helper function.
* Merged patch 4 to patch 1 as mainline commit 9d3de7ee192a fixed the issue.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3ext4: add two helper functions extent_logical_end() and pa_logical_end()fs/ext4/mballoc.c fs/ext4/mballoc.h+17 -63 replies
2/3ext4: fix BUG in ext4_mb_new_inode_pa() due to overflowfs/ext4/mballoc.c+14 -172 replies
3/3ext4: avoid overlapping preallocations due to overflowfs/ext4/mballoc.c+10 -112 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchRitesh Harjani (IBM)Jan Kara
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] ext4: fix some ext4_lblk_t overflow issues

Changes since v1:
* Rename fex_end() and pa_end() to extent_logical_end() and pa_logical_end() to make the code more readable.
* Refactor the logic for adjusting the best extent in ext4_mb_new_inode_pa() to simplify the code and remove redundant parameter for helper function.
* Merged patch 4 to patch 1 as mainline commit 9d3de7ee192a fixed the issue.

Baokun Li (3):
ext4: add two helper functions extent_logical_end() and pa_logical_end()
ext4: fix BUG in ext4_mb_new_inode_pa() due to overflow
ext4: avoid overlapping preallocations due to overflow

 fs/ext4/mballoc.c | 61 +++++++++++++++++++++--------------------------
 fs/ext4/mballoc.h | 14 +++++++++++
 2 files changed, 41 insertions(+), 34 deletions(-)
Signature · 1 line
2.31.1