target/s390x: Miscellaneous TCG fixes, part 2
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest14 patches 2 repliesIn review
- v314 patches 7 repliesSuperseded
- v214 patches 13 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 14 patches | 8 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | target/s390x: Make CKSM raise an exception if R2 is oddtarget/ target/ | +7 | 2 replies | |
| 2/14 | target/s390x: Fix CLM with M3=0target/ | +5 | 0 replies | |
| 3/14 | target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputstarget/ | +2 | 0 replies | |
| 4/14 | target/s390x: Fix ICM with M3=0target/ | +6 | 0 replies | |
| 5/14 | target/s390x: Make MC raise specification exception when class >= 16target/ target/ | +3 | 0 replies | |
| 6/14 | tcg/{i386, s390x}: Add earlyclobber to the op_add2's first outputtcg/ tcg/ tcg/ +2 more | +19 | 0 replies | |
| 7/14 | target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13target/ | +1 | 0 replies | |
| 8/14 | tests/tcg/s390x: Test CKSMtests/ tests/ | +30 | 0 replies | |
| 9/14 | tests/tcg/s390x: Test CLGEBR and CGEBRAtests/ tests/ tests/ | +69 | 0 replies | |
| 10/14 | tests/tcg/s390x: Test CLMtests/ tests/ | +30 | 0 replies | |
| 11/14 | tests/tcg/s390x: Test ICMtests/ tests/ | +33 | 0 replies | |
| 12/14 | tests/tcg/s390x: Test MCtests/ tests/ | +57 | 0 replies | |
| 13/14 | tests/tcg/s390x: Test STPQtests/ tests/ | +21 | 0 replies | |
| 14/14 | tests/tcg/s390x: Test VCKSMtests/ tests/ tests/ | +34 | 0 replies |
Reviews trailers per patch
7 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Thomas Huth | Richard Henderson | David Hildenbrand |
|---|---|---|---|
| 1/14 | R-b | R-b | |
| 2/14 | R-b | R-b | |
| 3/14 | R-b | R-b | |
| 4/14 | R-b | R-b | |
| 5/14 | R-b | R-b | |
| 6/14 | R-b | ||
| 7/14 | R-b | R-b | |
| 8/14 | |||
| 9/14 | T-b | ||
| 10/14 | T-b | ||
| 11/14 | T-b | ||
| 12/14 | T-b | ||
| 13/14 | T-b | ||
| 14/14 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 00/14] target/s390x: Miscellaneous TCG fixes, part 2
v3: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03902.html
v3 -> v4: Introduce in2_ra2_E (Richard).
Use probe_read (Richard).
Add R-bs.
Patches needing review: [01/14], [08/14]-[14/14].
v2: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03762.html
v2 -> v3: Document the new constraint set (Philippe).
Fix clang build (Thomas).
Add T-bs.
v1: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03648.html
v1 -> v2: Move the case in 04/14 (David).
Simplify the reserved type checking in 07/14 (David). Add R-bs.
Hi,
Here is another set of fixes for issues found by randomized testing.
Most of them have to do with simple insufficient error handling or corner cases, but 3/14 and 6/14 took a while to figure out, and hopefully I got the fixes right. 13/14 is a test for an issue that Richard has already fixed, but I thought it would be helpful to have it anyway.
Best regards,
Ilya
Ilya Leoshkevich (14):
target/s390x: Make CKSM raise an exception if R2 is odd target/s390x: Fix CLM with M3=0
target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs target/s390x: Fix ICM with M3=0
target/s390x: Make MC raise specification exception when class >= 16 tcg/{i386,s390x}: Add earlyclobber to the op_add2's first output target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13 tests/tcg/s390x: Test CKSM
tests/tcg/s390x: Test CLGEBR and CGEBRA
tests/tcg/s390x: Test CLM
tests/tcg/s390x: Test ICM
tests/tcg/s390x: Test MC
tests/tcg/s390x: Test STPQ
tests/tcg/s390x: Test VCKSM
target/s390x/tcg/excp_helper.c | 2 +- target/s390x/tcg/fpu_helper.c | 3 +- target/s390x/tcg/insn-data.h.inc | 2 +- target/s390x/tcg/mem_helper.c | 5 +++ target/s390x/tcg/translate.c | 16 ++++++- target/s390x/tcg/translate_vx.c.inc | 2 +- tcg/i386/tcg-target-con-set.h | 5 ++- tcg/i386/tcg-target.c.inc | 2 +- tcg/s390x/tcg-target-con-set.h | 8 ++-- tcg/s390x/tcg-target.c.inc | 4 +- tcg/tcg.c | 8 +++- tests/tcg/s390x/Makefile.softmmu-target | 5 +++ tests/tcg/s390x/Makefile.target | 6 +++ tests/tcg/s390x/cgebra.c | 32 ++++++++++++++ tests/tcg/s390x/cksm.S | 29 +++++++++++++ tests/tcg/s390x/clgebr.c | 32 ++++++++++++++ tests/tcg/s390x/clm.S | 29 +++++++++++++ tests/tcg/s390x/icm.S | 32 ++++++++++++++ tests/tcg/s390x/mc.S | 56 +++++++++++++++++++++++++ tests/tcg/s390x/stpq.S | 20 +++++++++ tests/tcg/s390x/vcksm.c | 31 ++++++++++++++ tests/tcg/s390x/vx.h | 2 + 22 files changed, 317 insertions(+), 14 deletions(-) create mode 100644 tests/tcg/s390x/cgebra.c create mode 100644 tests/tcg/s390x/cksm.S create mode 100644 tests/tcg/s390x/clgebr.c create mode 100644 tests/tcg/s390x/clm.S create mode 100644 tests/tcg/s390x/icm.S create mode 100644 tests/tcg/s390x/mc.S create mode 100644 tests/tcg/s390x/stpq.S create mode 100644 tests/tcg/s390x/vcksm.c
Signature · 1 line
2.41.0