Skip to content

target/s390x: Miscellaneous TCG fixes, part 2

Ilya Leoshkevich qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 2 repliesIn review
  2. v314 patches 7 repliesSuperseded
  3. v214 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v114 patches8 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14target/s390x: Make CKSM raise an exception if R2 is oddtarget/s390x/tcg/insn-data.h.inc target/s390x/tcg/translate.c+7 -12 replies
2/14target/s390x: Fix CLM with M3=0target/s390x/tcg/mem_helper.c+5 -00 replies
3/14target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputstarget/s390x/tcg/fpu_helper.c+2 -10 replies
4/14target/s390x: Fix ICM with M3=0target/s390x/tcg/translate.c+6 -00 replies
5/14target/s390x: Make MC raise specification exception when class >= 16target/s390x/tcg/excp_helper.c target/s390x/tcg/translate.c+3 -30 replies
6/14tcg/{i386, s390x}: Add earlyclobber to the op_add2's first outputtcg/i386/tcg-target-con-set.h tcg/i386/tcg-target.c.inc tcg/s390x/tcg-target-con-set.h +2 more+19 -80 replies
7/14target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13target/s390x/tcg/translate_vx.c.inc+1 -10 replies
8/14tests/tcg/s390x: Test CKSMtests/tcg/s390x/Makefile.softmmu-target tests/tcg/s390x/cksm.S+30 -00 replies
9/14tests/tcg/s390x: Test CLGEBR and CGEBRAtests/tcg/s390x/Makefile.target tests/tcg/s390x/cgebra.c tests/tcg/s390x/clgebr.c+69 -00 replies
10/14tests/tcg/s390x: Test CLMtests/tcg/s390x/Makefile.softmmu-target tests/tcg/s390x/clm.S+30 -00 replies
11/14tests/tcg/s390x: Test ICMtests/tcg/s390x/Makefile.softmmu-target tests/tcg/s390x/icm.S+33 -00 replies
12/14tests/tcg/s390x: Test MCtests/tcg/s390x/Makefile.softmmu-target tests/tcg/s390x/mc.S+57 -00 replies
13/14tests/tcg/s390x: Test STPQtests/tcg/s390x/Makefile.softmmu-target tests/tcg/s390x/stpq.S+21 -00 replies
14/14tests/tcg/s390x: Test VCKSMtests/tcg/s390x/Makefile.target tests/tcg/s390x/vcksm.c tests/tcg/s390x/vx.h+34 -00 replies

Reviews trailers per patch

7 of 14 patches have a Reviewed-by or Acked-by.

PatchThomas HuthRichard HendersonDavid Hildenbrand
1/14R-b R-b
2/14R-b R-b
3/14R-b R-b
4/14R-b R-b
5/14R-b R-b
6/14R-b
7/14R-b R-b
8/14
9/14T-b
10/14T-b
11/14T-b
12/14T-b
13/14T-b
14/14T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/14] target/s390x: Miscellaneous TCG fixes, part 2

v3: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03902.html
v3 -> v4: Introduce in2_ra2_E (Richard).
Use probe_read (Richard).
Add R-bs.
Patches needing review: [01/14], [08/14]-[14/14].

v2: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03762.html
v2 -> v3: Document the new constraint set (Philippe).
Fix clang build (Thomas).
Add T-bs.

v1: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03648.html
v1 -> v2: Move the case in 04/14 (David).
Simplify the reserved type checking in 07/14 (David). Add R-bs.

Hi,

Here is another set of fixes for issues found by randomized testing.

Most of them have to do with simple insufficient error handling or corner cases, but 3/14 and 6/14 took a while to figure out, and hopefully I got the fixes right. 13/14 is a test for an issue that Richard has already fixed, but I thought it would be helpful to have it anyway.

Best regards,
Ilya

Ilya Leoshkevich (14):
target/s390x: Make CKSM raise an exception if R2 is odd target/s390x: Fix CLM with M3=0
target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs target/s390x: Fix ICM with M3=0
target/s390x: Make MC raise specification exception when class >= 16 tcg/{i386,s390x}: Add earlyclobber to the op_add2's first output target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13 tests/tcg/s390x: Test CKSM
tests/tcg/s390x: Test CLGEBR and CGEBRA
tests/tcg/s390x: Test CLM
tests/tcg/s390x: Test ICM
tests/tcg/s390x: Test MC
tests/tcg/s390x: Test STPQ
tests/tcg/s390x: Test VCKSM

 target/s390x/tcg/excp_helper.c          |  2 +-
 target/s390x/tcg/fpu_helper.c           |  3 +-
 target/s390x/tcg/insn-data.h.inc        |  2 +-
 target/s390x/tcg/mem_helper.c           |  5 +++
 target/s390x/tcg/translate.c            | 16 ++++++-
 target/s390x/tcg/translate_vx.c.inc     |  2 +-
 tcg/i386/tcg-target-con-set.h           |  5 ++-
 tcg/i386/tcg-target.c.inc               |  2 +-
 tcg/s390x/tcg-target-con-set.h          |  8 ++--
 tcg/s390x/tcg-target.c.inc              |  4 +-
 tcg/tcg.c                               |  8 +++-
 tests/tcg/s390x/Makefile.softmmu-target |  5 +++
 tests/tcg/s390x/Makefile.target         |  6 +++
 tests/tcg/s390x/cgebra.c                | 32 ++++++++++++++
 tests/tcg/s390x/cksm.S                  | 29 +++++++++++++
 tests/tcg/s390x/clgebr.c                | 32 ++++++++++++++
 tests/tcg/s390x/clm.S                   | 29 +++++++++++++
 tests/tcg/s390x/icm.S                   | 32 ++++++++++++++
 tests/tcg/s390x/mc.S                    | 56 +++++++++++++++++++++++++
 tests/tcg/s390x/stpq.S                  | 20 +++++++++
 tests/tcg/s390x/vcksm.c                 | 31 ++++++++++++++
 tests/tcg/s390x/vx.h                    |  2 +
 22 files changed, 317 insertions(+), 14 deletions(-)
 create mode 100644 tests/tcg/s390x/cgebra.c
 create mode 100644 tests/tcg/s390x/cksm.S
 create mode 100644 tests/tcg/s390x/clgebr.c
 create mode 100644 tests/tcg/s390x/clm.S
 create mode 100644 tests/tcg/s390x/icm.S
 create mode 100644 tests/tcg/s390x/mc.S
 create mode 100644 tests/tcg/s390x/stpq.S
 create mode 100644 tests/tcg/s390x/vcksm.c
Signature · 1 line
2.41.0