bcachefs: write buffer journaling fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | bcachefs: remove duplicate code between backpointer update pathsfs/ fs/ | +5 | 0 replies | |
| 2/5 | bcachefs: remove unnecessary btree_insert_key_leaf() wrapperfs/ | +1 | 0 replies | |
| 3/5 | bcachefs: fold bch2_trans_update_by_path_trace() into callersfs/ | +8 | 0 replies | |
| 4/5 | bcachefs: support btree updates of prejournaled keysfs/ fs/ fs/ +1 more | +36 | 0 replies | |
| 5/5 | bcachefs: use prejournaled key updates for write buffer flushesfs/ | +28 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] bcachefs: write buffer journaling fixes
Hi all,
Here are a few patches to try and address the write buffer journaling issue that occasionally produces backpointer inconsistency errors via generic/388. The issue is described in more detail in patch 5.
Patches 1-3 are just a few cleanup/prep patches that fell out of perusing the code. Patch 4 adds the ability to plumb a known seq for a journaled key into a transaction and down through to the btree update. Patch 5 updates write buffer key flushing to use the wb key journal seq for the key in the flush transaction.
This survived ~100 or so iterations of generic/388 in my last test and the series is also pushed to the CI [1]. Thoughts, reviews, flames appreciated.
Brian
Brian Foster (5):
bcachefs: remove duplicate code between backpointer update paths
bcachefs: remove unnecessary btree_insert_key_leaf() wrapper
bcachefs: fold bch2_trans_update_by_path_trace() into callers
bcachefs: support btree updates of prejournaled keys
bcachefs: use prejournaled key updates for write buffer flushes
fs/bcachefs/backpointers.c | 18 +-------- fs/bcachefs/backpointers.h | 8 ++-- fs/bcachefs/bkey_methods.h | 2 + fs/bcachefs/btree_types.h | 1 + fs/bcachefs/btree_update.h | 2 + fs/bcachefs/btree_update_leaf.c | 67 +++++++++++++++++++------------- fs/bcachefs/btree_write_buffer.c | 30 +++++++++++++- 7 files changed, 77 insertions(+), 51 deletions(-)
Signature · 1 line
2.40.1