Skip to content

configure.ac: misc configure fixes

Andreas Herrmann git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3configure.ac: don't overwrite NO_EXPAT optionconfigure.ac+4 -00 replies
2/3configure.ac: don't overwrite NO_CURL optionconfigure.ac+4 -00 replies
3/3configure.ac: always save NO_ICONV to config.statusconfigure.ac+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] configure.ac: misc configure fixes

Some of the configure options are not working as expected. I first encountered this when using '--with-expat=no'. Following patches address this.

I've also checked configure options for 'libpcre', 'openssl' (together with 'make OPENSSL_SHA1=yes ...'), and 'tcltk'. These are working correctly.

As a test I've run 'make test' when disabling support of a package. I always had to use 'export GIT_SKIP_TESTS="t5801.1[4-7] t5801.31"' to skip some failing tests. Those failed also with default build.

When disabling iconv ('configure --without-iconv') further tests are failing. In this case I've used
'export GIT_SKIP_TESTS="t5801.1[4-7] t5801.31 \
t0028* t2082.2 t3434* t390[01]* \
t4041* t4059* t4060.8 t4201.12 t4205* t4210* t4254.[34] \
t5100* t6006* t7102.2 t8005* t9300.193 t9350*"'
to ensure that 'make test' completed without exiting early.

Andreas Herrmann (3):
configure.ac: don't overwrite NO_EXPAT option configure.ac: don't overwrite NO_CURL option configure.ac: always save NO_ICONV to config.status

 configure.ac | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Signature · 1 line
2.41.0