Skip to content

tcp: add missing annotations

Eric Dumazet netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesApplied 11/11

Patches in v1 All 11 applied

#Subject and filesSizeRepliesApplied
1/11tcp: annotate data-races around tp->tcp_tx_delaynet/ipv4/tcp.c+2 -20 repliesApplied
2/11tcp: annotate data-races around tp->tsoffsetnet/ipv4/tcp.c net/ipv4/tcp_ipv4.c+5 -40 repliesApplied
3/11tcp: annotate data-races around tp->keepalive_timeinclude/net/tcp.h net/ipv4/tcp.c+7 -30 repliesApplied
4/11tcp: annotate data-races around tp->keepalive_intvlinclude/net/tcp.h net/ipv4/tcp.c+9 -40 repliesApplied
5/11tcp: annotate data-races around tp->keepalive_probesinclude/net/tcp.h net/ipv4/tcp.c+10 -40 repliesApplied
6/11tcp: annotate data-races around icsk->icsk_syn_retriesnet/ipv4/inet_connection_sock.c net/ipv4/tcp.c+4 -40 repliesApplied
7/11tcp: annotate data-races around tp->linger2net/ipv4/tcp.c+4 -40 repliesApplied
8/11tcp: annotate data-races around rskq_defer_acceptnet/ipv4/tcp.c+6 -50 repliesApplied
9/11tcp: annotate data-races around tp->notsent_lowatinclude/net/tcp.h net/ipv4/tcp.c+7 -30 repliesApplied
10/11tcp: annotate data-races around icsk->icsk_user_timeoutnet/ipv4/tcp.c+3 -30 repliesApplied
11/11tcp: annotate data-races around fastopenq.max_qleninclude/linux/tcp.h net/ipv4/tcp.c net/ipv4/tcp_fastopen.c+6 -40 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 00/11] tcp: add missing annotations

This series was inspired by one syzbot (KCSAN) report.

do_tcp_getsockopt() does not lock the socket, we need to annotate most of the reads there (and other places as well).

This is a first round, another series will come later.

Eric Dumazet (11):
tcp: annotate data-races around tp->tcp_tx_delay
tcp: annotate data-races around tp->tsoffset
tcp: annotate data-races around tp->keepalive_time
tcp: annotate data-races around tp->keepalive_intvl
tcp: annotate data-races around tp->keepalive_probes
tcp: annotate data-races around icsk->icsk_syn_retries
tcp: annotate data-races around tp->linger2
tcp: annotate data-races around rskq_defer_accept
tcp: annotate data-races around tp->notsent_lowat
tcp: annotate data-races around icsk->icsk_user_timeout
tcp: annotate data-races around fastopenq.max_qlen

 include/linux/tcp.h             |  2 +-
 include/net/tcp.h               | 31 ++++++++++++++----
 net/ipv4/inet_connection_sock.c |  2 +-
 net/ipv4/tcp.c                  | 57 +++++++++++++++++----------------
 net/ipv4/tcp_fastopen.c         |  6 ++--
 net/ipv4/tcp_ipv4.c             |  5 +--
 6 files changed, 63 insertions(+), 40 deletions(-)
Signature · 1 line
2.41.0.255.g8b1d071c50-goog