Serial core controller port device name fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 13 repliesIn review
- v43 patches 5 repliesSuperseded
- v33 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 9 replies | Superseded |
Changes in v5 from the cover letter
- Make the sysfs device names nicer with DEVNAME:0.0 naming, the "ctrl" and "port" prefixes are not needed with the controller id in the name
- Fix Andy's Reviewed-by as noted by Andy
- Generate patches with --patience to make the last patch more readable
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | serial: core: Controller id cannot be negativeinclude/ | +1 | 0 replies | |
| 2/3 | serial: core: Fix serial core port id to not use port->linedrivers/ drivers/ include/ | +4 | 0 replies | |
| 3/3 | serial: core: Fix serial core controller port name to show controller iddrivers/ | +20 | 13 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/3] Serial core controller port device name fixes
A few issues have been found with device naming for the serial core controller port device. These issues currently mostly affect the output for /sys/bus/serial-base/devices, but need to be also fixed to avoid port addressing issues later on.
Changes since v4:
- Make the sysfs device names nicer with DEVNAME:0.0 naming, the "ctrl" and "port" prefixes are not needed with the controller id in the name
- Fix Andy's Reviewed-by as noted by Andy
- Generate patches with --patience to make the last patch more readable
Changes since v3:
- Drop unnecessary else on the return path in serial_base_device_init() as noted by Andy
- Add Andy's Reviewed-by
- Update patch description for port_id instead of port port_id for the first patch
Changes since v2:
- Fix my email script as it had started to drop linux-serial as noted by Greg
- Explain why we're changing ctrl_id as requested by Greg
Changes since v1:
- Port id cannot be negative as noted by Jiri
- Controller id cannot be negative as noted by Andy
- Port name is missing the controller instance as noted by Andy
Tony Lindgren (3):
serial: core: Controller id cannot be negative
serial: core: Fix serial core port id to not use port->line
serial: core: Fix serial core controller port name to show controller
id
drivers/tty/serial/8250/8250_core.c | 2 ++ drivers/tty/serial/serial_base_bus.c | 32 +++++++++++++++++----------- include/linux/serial_core.h | 3 ++- 3 files changed, 24 insertions(+), 13 deletions(-)
Signature · 1 line
2.41.0