Skip to content

Intel: sof_rt5682: remove quirk flag

Brent Lu alsa-devel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest1 patch 5 repliesIn review
  2. v32 patches 2 repliesSuperseded
  3. v22 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches13 repliesSuperseded

Changes in v4 from the cover letter

- merge two patches to avoid build break
- remove redundant assignment in max_98390_hw_params()
- refactor MAX_98390_DEVX_NAME macros

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1ASoC: Intel: maxim-common: get codec number from ACPI tablesound/soc/intel/boards/sof_maxim_common.c sound/soc/intel/boards/sof_maxim_common.h sound/soc/intel/boards/sof_rt5682.c+111 -1173 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchBard LiaoPierre-Louis BossartAndy Shevchenko
1/1R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/1] Intel: sof_rt5682: remove quirk flag

We add a helper function to detect amplifier number according to device instance in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi quirk for 4-amplifier configuration could be safely removed.

Also refactor the max_98390_hw_params() function to use an array to handle the TDM parameter.

Amplifier number detection and TDM parameter are tested on two Chromebooks. One with 2 MAX98390 and one with 4 MAX98390 amplifier.

V2 Changes:
- fix some typos in cover letter
- use for_each_acpi_dev_match() macro to simplify the codec
- use 'unsign int' for codec number variable

V3 Changes:
- replace pr_err() with dev_err()

V4 Changes:
- merge two patches to avoid build break
- remove redundant assignment in max_98390_hw_params()
- refactor MAX_98390_DEVX_NAME macros

Brent Lu (2):
ASoC: Intel: maxim-common: get codec number from ACPI
ASoC: Intel: sof_rt5682: remove SOF_MAX98390_TWEETER_SPEAKER_PRESENT
flag

Brent Lu (1):
ASoC: Intel: maxim-common: get codec number from ACPI table

 sound/soc/intel/boards/sof_maxim_common.c | 170 +++++++++++++---------
 sound/soc/intel/boards/sof_maxim_common.h |  21 ++-
 sound/soc/intel/boards/sof_rt5682.c       |  37 +----
 3 files changed, 111 insertions(+), 117 deletions(-)
Signature · 1 line
2.34.1