Skip to content

tools/xenstore: fix get_spec_node()

Juergen Gross xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 5 repliesIn review
  2. v22 patches 7 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- add get_strings() conversion to const in patch 1

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tools/xenstore: add const to the return type of canonicalize()tools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h +6 more+49 -431 reply
2/2tools/xenstore: fix get_spec_node()tools/xenstore/xenstored_core.c+4 -14 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJulien Grall
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] tools/xenstore: fix get_spec_node()

Small series to fix a bug in get_spec_node().

Patch 1 is turning several function parameters into const in order to avoid having to cast away the const attribute in get_spec_node().

Patch 2 is the fix, which is a backport candidate.

Changes in V3:
- add get_strings() conversion to const in patch 1

Changes in V2:
- add patch 1, avoiding the need to cast const away in patch 2

Juergen Gross (2):
tools/xenstore: add const to the return type of canonicalize() tools/xenstore: fix get_spec_node()

 tools/xenstore/xenstored_control.c   | 33 ++++++++++++++--------------
 tools/xenstore/xenstored_core.c      | 31 +++++++++++++++-----------
 tools/xenstore/xenstored_core.h      |  5 +++--
 tools/xenstore/xenstored_domain.c    |  4 ++--
 tools/xenstore/xenstored_lu.c        |  2 +-
 tools/xenstore/xenstored_lu.h        |  4 ++--
 tools/xenstore/xenstored_lu_daemon.c |  2 +-
 tools/xenstore/xenstored_lu_minios.c |  2 +-
 tools/xenstore/xenstored_watch.c     | 14 +++++++-----
 9 files changed, 53 insertions(+), 44 deletions(-)
Signature · 1 line
2.35.3