Skip to content

net/sched Bind logic fixes for cls_fw, cls_u32 and cls_route

valis netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-freenet/sched/cls_u32.c+0 -14 replies
2/3net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-freenet/sched/cls_fw.c+0 -10 replies
3/3net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-freenet/sched/cls_route.c+0 -10 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPedro TammelaJamal Hadi SalimM A RamdhanGreg KHMichael Dolan
SeriesR-b T-b A-b R-b T-b A-b A-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH net 0/3] net/sched Bind logic fixes for cls_fw, cls_u32 and cls_route

Three classifiers (cls_fw, cls_u32 and cls_route) always copy tcf_result struct into the new instance of the filter on update.

This causes a problem when updating a filter bound to a class, as tcf_unbind_filter() is always called on the old instance in the success path, decreasing filter_cnt of the still referenced class and allowing it to be deleted, leading to a use-after-free.

This patch set fixes this issue in all affected classifiers by no longer copying the tcf_result struct from the old filter.

valis (3):
net/sched: cls_u32: No longer copy tcf_result on update to avoid
use-after-free
net/sched: cls_fw: No longer copy tcf_result on update to avoid
use-after-free
net/sched: cls_route: No longer copy tcf_result on update to avoid
use-after-free

 net/sched/cls_fw.c    | 1 -
 net/sched/cls_route.c | 1 -
 net/sched/cls_u32.c   | 1 -
 3 files changed, 3 deletions(-)
Signature · 1 line
2.30.2