Skip to content

Multiple cleanup patches for the UFS driver

Bart Van Assche linux-next linux-scsi 2 versions – Applied

Status from this message: Applied to 6.6/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 10 repliesApplied
  2. v112 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Introduced a name for the data direction enumeration type.
- Instead of introducing struct utp_upiu_hdr as an alias for struct utp_upiu_header, introduce a union in the latter data structure.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/12scsi: ufs: Follow the kernel-doc syntax for documenting return valuesdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +8 more+126 -1220 replies
2/12scsi: ufs: Document all return valuesdrivers/ufs/core/ufs_bsg.c drivers/ufs/core/ufshcd.c drivers/ufs/host/cdns-pltfrm.c +1 more+44 -20 replies
3/12scsi: ufs: Fix kernel-doc headersdrivers/ufs/host/cdns-pltfrm.c drivers/ufs/host/tc-dwc-g210.c drivers/ufs/host/ufshcd-dwc.c+16 -330 replies
4/12scsi: ufs: Rename a function argumentdrivers/ufs/core/ufs-hwmon.c+2 -10 replies
5/12scsi: ufs: Minimize #include directivesinclude/ufs/ufs.h include/ufs/ufshcd.h include/ufs/ufshci.h+4 -20 replies
6/12scsi: ufs: Simplify zero-initializationdrivers/ufs/core/ufshcd.c+2 -20 replies
7/12scsi: ufs: Improve type safetydrivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c include/ufs/ufs.h +1 more+7 -140 replies
8/12scsi: ufs: Remove a local variable from ufshcd_abort_all()drivers/ufs/core/ufshcd.c+11 -110 replies
9/12scsi: ufs: Simplify ufshcd_abort_all()drivers/ufs/core/ufshcd.c+20 -262 replies
10/12scsi: ufs: Remove a member variabledrivers/ufs/core/ufshcd.c include/ufs/ufs.h include/ufs/ufshcd.h+20 -250 replies
11/12scsi: ufs: Simplify transfer request header initializationdrivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd-crypto.h drivers/ufs/core/ufshcd.c +2 more+99 -585 replies
12/12scsi: ufs: Simplify response header parsingdrivers/ufs/core/ufshcd.c include/uapi/scsi/scsi_bsg_ufs.h include/ufs/ufs.h+115 -1081 reply

Reviews trailers per patch

4 of 12 patches have a Reviewed-by or Acked-by.

PatchAvri Altman
1/12
2/12
3/12
4/12R-b
5/12
6/12
7/12
8/12
9/12
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] Multiple cleanup patches for the UFS driver

Hi Martin,

This patch includes the following changes, none of which should change the functionality of the UFS host controller driver:
- Improve the kernel-doc headers further.
- Fix multiple W=2 compiler warnings.
- Simplify ufshcd_abort_all().
- Simplify the code for creating and parsing UFS Transport Protocol (UTP) headers.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v1:
- Introduced a name for the data direction enumeration type.
- Instead of introducing struct utp_upiu_hdr as an alias for struct utp_upiu_header, introduce a union in the latter data structure.

Bart Van Assche (12):
scsi: ufs: Follow the kernel-doc syntax for documenting return values
scsi: ufs: Document all return values
scsi: ufs: Fix kernel-doc headers
scsi: ufs: Rename a function argument
scsi: ufs: Minimize #include directives
scsi: ufs: Simplify zero-initialization
scsi: ufs: Improve type safety
scsi: ufs: Remove a local variable from ufshcd_abort_all()
scsi: ufs: Simplify ufshcd_abort_all()
scsi: ufs: Remove a member variable
scsi: ufs: Simplify transfer request header initialization
scsi: ufs: Simplify response header parsing

 drivers/ufs/core/ufs-hwmon.c       |   3 +-
 drivers/ufs/core/ufs-mcq.c         |  17 +-
 drivers/ufs/core/ufs_bsg.c         |   2 +
 drivers/ufs/core/ufshcd-crypto.h   |  20 +-
 drivers/ufs/core/ufshcd-priv.h     |   4 +-
 drivers/ufs/core/ufshcd.c          | 529 +++++++++++++++--------------
 drivers/ufs/host/cdns-pltfrm.c     |  27 +-
 drivers/ufs/host/tc-dwc-g210-pci.c |   2 +-
 drivers/ufs/host/tc-dwc-g210.c     |  32 +-
 drivers/ufs/host/ufs-mediatek.c    |   6 +-
 drivers/ufs/host/ufs-qcom.c        |   8 +-
 drivers/ufs/host/ufshcd-dwc.c      |  22 +-
 drivers/ufs/host/ufshcd-pci.c      |   2 +-
 drivers/ufs/host/ufshcd-pltfrm.c   |   6 +-
 include/uapi/scsi/scsi_bsg_ufs.h   |  52 ++-
 include/ufs/ufs.h                  |  47 +--
 include/ufs/ufshcd.h               |  26 +-
 include/ufs/ufshci.h               |  53 ++-
 18 files changed, 460 insertions(+), 398 deletions(-)