Skip to content

rbd: reduce the potential for erroneous blocklisting

Ilya Dryomov ceph-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

- ceph_addr_is_blank() was missing an export
- amended locker equality semantics to ignore addr->type and moved the function to rbd.c

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3rbd: make get_lock_owner_info() return a single locker or NULLdrivers/block/rbd.c+51 -330 replies
2/3rbd: harden get_lock_owner_info() a bitdrivers/block/rbd.c net/ceph/messenger.c+16 -60 replies
3/3rbd: retrieve and check lock owner twice before blocklistingdrivers/block/rbd.c+23 -22 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] rbd: reduce the potential for erroneous blocklisting

Hello,

This came out of snapshot-based mirroring work. Patches 1 and 2 are preparatory, patch 3 fixes the issue (in as much as reasonable).

v1 -> v2:
- ceph_addr_is_blank() was missing an export
- amended locker equality semantics to ignore addr->type and moved the function to rbd.c

Thanks,

Ilya

Ilya Dryomov (3):
rbd: make get_lock_owner_info() return a single locker or NULL
rbd: harden get_lock_owner_info() a bit
rbd: retrieve and check lock owner twice before blocklisting

 drivers/block/rbd.c  | 124 ++++++++++++++++++++++++++++++-------------
 net/ceph/messenger.c |   1 +
 2 files changed, 87 insertions(+), 38 deletions(-)
Signature · 1 line
2.41.0