Skip to content

x86: remaining -Wmissing-prototype warning fixes

Arnd Bergmann lkml 3 versions – Applied

Status from this message: The following commit has been merged into the x86/cleanups branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyApplied
  2. v21 patch 0 repliesApplied
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- add amd_check_microcode() patch to the series. I had sent that separately as this was a regression in 6.5-rc

- rework comment for __div64_32

- split paravirt patch into two patches and rewrite the native_pv_lock_init() one as requested by Boris

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7x86: Fix amd_check_microcode() declarationarch/x86/include/asm/microcode_amd.h arch/x86/include/asm/processor.h+3 -20 replies
2/7x86: apic: hide unused safe_smp_processor_id on UParch/x86/kernel/apic/ipi.c+2 -00 replies
3/7x86: avoid unneeded __div64_32 function definitionarch/x86/include/asm/div64.h+6 -00 replies
4/7x86: purgatory: include header for warn() declarationarch/x86/boot/compressed/error.c arch/x86/boot/compressed/error.h arch/x86/purgatory/purgatory.c+3 -20 replies
5/7x86: alternative: add __alt_reloc_selftest prototypearch/x86/kernel/alternative.c+1 -00 replies
6/7x86: paravirt: shut up unused native_pv_lock_init() function warningarch/x86/include/asm/paravirt.h arch/x86/include/asm/qspinlock.h arch/x86/kernel/paravirt.c+10 -70 replies
7/7x86: qspinlock-paravirt: fix mising-prototype warningarch/x86/include/asm/qspinlock_paravirt.h kernel/locking/qspinlock_paravirt.h+12 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/7] x86: remaining -Wmissing-prototype warning fixes

From: Arnd Bergmann <[email protected]>

This is almost the same as before, and should let us turn on -Wmissing-prototypes by default. I'm still unsure whether we need to do this per architecture as some other ones still produce a lot of warnings, or we just enabled it for everyone and let arch maintainers deal with it now that the major ones (x86, arm64, arm, powerpc, riscv, s390) are clean.

Changes compared to v2:
- add amd_check_microcode() patch to the series. I had sent that separately as this was a regression in 6.5-rc

- rework comment for __div64_32

- split paravirt patch into two patches and rewrite the native_pv_lock_init() one as requested by Boris

Arnd

Arnd Bergmann (7):
x86: Fix amd_check_microcode() declaration
x86: apic: hide unused safe_smp_processor_id on UP
x86: avoid unneeded __div64_32 function definition
x86: purgatory: include header for warn() declaration
x86: alternative: add __alt_reloc_selftest prototype
x86: paravirt: shut up unused native_pv_lock_init() function warning
x86: qspinlock-paravirt: fix mising-prototype warning

 arch/x86/boot/compressed/error.c          |  2 +-
 arch/x86/boot/compressed/error.h          |  2 +-
 arch/x86/include/asm/div64.h              |  6 ++++++
 arch/x86/include/asm/microcode_amd.h      |  3 +--
 arch/x86/include/asm/paravirt.h           |  7 +++++++
 arch/x86/include/asm/processor.h          |  2 ++
 arch/x86/include/asm/qspinlock.h          |  7 +------
 arch/x86/include/asm/qspinlock_paravirt.h |  2 ++
 arch/x86/kernel/alternative.c             |  1 +
 arch/x86/kernel/apic/ipi.c                |  2 ++
 arch/x86/kernel/paravirt.c                |  3 ++-
 arch/x86/purgatory/purgatory.c            |  1 +
 kernel/locking/qspinlock_paravirt.h       | 20 ++++++++++----------
 13 files changed, 37 insertions(+), 21 deletions(-)
Signature · 1 line
2.39.2