i2c: designware: code consolidation & cleanups
Status from this message: Applied to for-next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest24 patches 9 repliesApplied
- v424 patches 20 repliesSuperseded
- v325 patches 26 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 12 patches | 4 replies | Superseded | |
| v1 | 9 patches | 25 replies | Superseded |
Changes in v5 from the cover letter
- collected tags (Serge, Jarkko, Andi)
- corrected commit messages in patches 7, 18, 19 (Andi)
- amended grammar in the patch 24 as suggested (Andi)
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | i2c: designware: Fix PM calls order in dw_i2c_plat_probe()drivers/ | +17 | 0 replies | |
| 2/24 | i2c: designware: Fix reset call order in dw_i2c_plat_probe()drivers/ | +34 | 0 replies | |
| 3/24 | i2c: designware: Let PCI core to take care about interrupt vectorsdrivers/ | +3 | 0 replies | |
| 4/24 | i2c: designware: Fix lock probe call order in dw_i2c_plat_probe()drivers/ | +12 | 0 replies | |
| 5/24 | i2c: designware: Replace a while-loop by for-loopdrivers/ | +1 | 0 replies | |
| 6/24 | i2c: designware: Save pointer to semaphore callbacks instead of indexdrivers/ drivers/ | +7 | 0 replies | |
| 7/24 | i2c: designware: Add missing 'c' into PCI IDs variable namedrivers/ | +3 | 1 reply | |
| 8/24 | i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()drivers/ drivers/ | +6 | 0 replies | |
| 9/24 | i2c: designware: Unify terminator in device ID tablesdrivers/ drivers/ | +3 | 0 replies | |
| 10/24 | i2c: designware: Always provide device ID tablesdrivers/ | +30 | 0 replies | |
| 11/24 | i2c: designware: Drop return value from i2c_dw_acpi_configure()drivers/ drivers/ | +3 | 0 replies | |
| 12/24 | i2c: designware: Drop return value from dw_i2c_of_configure()drivers/ | +2 | 0 replies | |
| 13/24 | i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure()drivers/ | +5 | 0 replies | |
| 14/24 | i2c: designware: Consolidate firmware parsing and configuring codedrivers/ drivers/ drivers/ +1 more | +66 | 0 replies | |
| 15/24 | i2c: designware: Unify the firmware type checksdrivers/ | +4 | 0 replies | |
| 16/24 | i2c: designware: Move exports to I2C_DW namespacesdrivers/ drivers/ drivers/ +2 more | +12 | 0 replies | |
| 17/24 | i2c: designware: Remove ->disable() callbackdrivers/ drivers/ drivers/ +3 more | +7 | 0 replies | |
| 18/24 | i2c: designware: Consolidate PM opsdrivers/ drivers/ drivers/ +1 more | +69 | 0 replies | |
| 19/24 | i2c: designware: Uninline i2c_dw_probe()drivers/ drivers/ | +16 | 0 replies | |
| 20/24 | i2c: designware: Propagate firmware nodedrivers/ drivers/ drivers/ | +2 | 0 replies | |
| 21/24 | i2c: designware: Use pci_get_drvdata()drivers/ | +2 | 0 replies | |
| 22/24 | i2c: designware: Use temporary variable for struct devicedrivers/ drivers/ | +27 | 0 replies | |
| 23/24 | i2c: designware: Get rid of redundant 'else'drivers/ | +3 | 0 replies | |
| 24/24 | i2c: designware: Fix spelling and other issues in the commentsdrivers/ drivers/ drivers/ +3 more | +32 | 2 replies |
Reviews trailers per patch
All 24 patches have a Reviewed-by or Acked-by.
| Patch | Andi Shyti | Serge Semin | Jarkko Nikula | Mario Limonciello |
|---|---|---|---|---|
| 1/24 | R-b | T-b | A-b | |
| 2/24 | R-b | T-b | A-b | |
| 3/24 | R-b | T-b | A-b | |
| 4/24 | R-b | T-b | A-b | |
| 5/24 | R-b | T-b | A-b | R-b |
| 6/24 | R-b | T-b | A-b | |
| 7/24 | R-b | T-b | A-b | |
| 8/24 | R-b | T-b | A-b T-b | R-b |
| 9/24 | R-b | T-b | A-b | R-b |
| 10/24 | R-b | T-b | A-b | R-b |
| 11/24 | R-b | T-b | A-b | |
| 12/24 | R-b | T-b | A-b | R-b |
| 13/24 | R-b | T-b | A-b | R-b |
| 14/24 | R-b | T-b | A-b | R-b |
| 15/24 | R-b | T-b | A-b | R-b |
| 16/24 | R-b | T-b | A-b | |
| 17/24 | R-b | T-b | A-b | |
| 18/24 | R-b | T-b | A-b | |
| 19/24 | R-b | T-b | A-b | |
| 20/24 | R-b | T-b | A-b | |
| 21/24 | R-b | T-b | A-b | |
| 22/24 | R-b | T-b | A-b | R-b |
| 23/24 | R-b | T-b | A-b | R-b |
| 24/24 | R-b | T-b | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v5 00/24] i2c: designware: code consolidation & cleanups
The series now consists the following groups of patches:
- fixing cleanup order in error path and remove (patches 1-4)
- refactoring i2c_dw_*_lock_support() (patches 5-6)
- refactoring module alias and device ID tables (patches 7-10)
- unifying firmware parsing and configuring code (patches 11-15)
- miscellaneous cleanups (patches 16-17,21-24)
- consolidating PM ops (patch 18)
- using device_set_node() for all drivers (patches 19-20)
Changelog v5:
- collected tags (Serge, Jarkko, Andi)
- corrected commit messages in patches 7, 18, 19 (Andi)
- amended grammar in the patch 24 as suggested (Andi)
v4: https://lore.kernel.org/r/[email protected]
Changelog v4:
- dropped first patch as controversial (Jarkko)
- dropped Fixes tag from a few patches (Jarkko)
- moved a hunk in patch 1 to patch 2 where it belongs (Jarkko)
- exported i2c_dw_disable() for modular building (Jarkko)
- added tags (Mario, Jarkko)
v3: https://lore.kernel.org/r/[email protected]
Changelog v3:
- doubled the size of the series
- fixed compilation error (LKP)
- added tags (Andi)
v2: https://lore.kernel.org/r/[email protected]
Changelog v2:
- reworked the series to make it less twisted (Jarkko, Andi)
- added tags to the patches that have been rebased (Andi, Mario, Jarkko)
- introduced a few new changes (PM ops, export namespace)
v1: https://lore.kernel.org/r/[email protected]
Andy Shevchenko (24):
i2c: designware: Fix PM calls order in dw_i2c_plat_probe()
i2c: designware: Fix reset call order in dw_i2c_plat_probe()
i2c: designware: Let PCI core to take care about interrupt vectors
i2c: designware: Fix lock probe call order in dw_i2c_plat_probe()
i2c: designware: Replace a while-loop by for-loop
i2c: designware: Save pointer to semaphore callbacks instead of index
i2c: designware: Add missing 'c' into PCI IDs variable name
i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()
i2c: designware: Unify terminator in device ID tables
i2c: designware: Always provide device ID tables
i2c: designware: Drop return value from i2c_dw_acpi_configure()
i2c: designware: Drop return value from dw_i2c_of_configure()
i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure()
i2c: designware: Consolidate firmware parsing and configuring code
i2c: designware: Unify the firmware type checks
i2c: designware: Move exports to I2C_DW namespaces
i2c: designware: Remove ->disable() callback
i2c: designware: Consolidate PM ops
i2c: designware: Uninline i2c_dw_probe()
i2c: designware: Propagate firmware node
i2c: designware: Use pci_get_drvdata()
i2c: designware: Use temporary variable for struct device
i2c: designware: Get rid of redundant 'else'
i2c: designware: Fix spelling and other issues in the comments
drivers/i2c/busses/i2c-designware-amdpsp.c | 14 +- drivers/i2c/busses/i2c-designware-common.c | 167 +++++++++- drivers/i2c/busses/i2c-designware-core.h | 47 +-- drivers/i2c/busses/i2c-designware-master.c | 19 +- drivers/i2c/busses/i2c-designware-pcidrv.c | 114 ++----- drivers/i2c/busses/i2c-designware-platdrv.c | 337 +++++++------------- drivers/i2c/busses/i2c-designware-slave.c | 12 +- 7 files changed, 339 insertions(+), 371 deletions(-)
Signature · 1 line
2.43.0.rc1.1.gbec44491f096