Skip to content

Switch to allowed_host

Daniel Wagner linux-block linux-nvme lkml 3 versions – Applied

Status from this message: I've applied the patches from 1 to 12. Of note is that I added "export" to the

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 9 repliesApplied
  2. v212 patches 6 repliesSuperseded
  3. v111 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- added new patch: "nvme/043: Use hostnqn to generate DHCAP key"
- removed unused variable in "nvme/rc: Add helper for adding/removing to allow list"
- added cleanup code to _nvmet_cleanup().

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/13nvme/{003,004,005,013,046,049}: Group all variables declarationstests/nvme/003 tests/nvme/004 tests/nvme/005 +3 more+9 -50 replies
2/13nvme: Reorganize test preamble code sectiontests/nvme/006 tests/nvme/007 tests/nvme/016 +17 more+69 -640 replies
3/13nvme/043: Use hostnqn to generate DHCAP keytests/nvme/043+1 -10 replies
4/13nvme/rc: Add common subsystem nqn definetests/nvme/rc+1 -00 replies
5/13nvme: Use def_subsysnqn variable instead local variabletests/nvme/003 tests/nvme/004 tests/nvme/005 +37 more+266 -2970 replies
6/13nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and hostidtests/nvme/041 tests/nvme/042 tests/nvme/043 +3 more+47 -750 replies
7/13nvme/rc: Add common file_path name definetests/nvme/rc+1 -00 replies
8/13nvme: Use def_file_path variable instead local variabletests/nvme/004 tests/nvme/005 tests/nvme/006 +31 more+103 -1380 replies
9/13nvme/rc: Add common def_subsys_uuid definetests/nvme/rc+1 -00 replies
10/13nvme: Use def_subsys_uuid variabletests/nvme/004 tests/nvme/005 tests/nvme/006 +25 more+28 -280 replies
11/13nvme/rc: Add helper for adding/removing to allow listtests/nvme/rc+18 -30 replies
12/13nvme: Add explicitly host to allow_host listtests/nvme/004 tests/nvme/005 tests/nvme/008 +23 more+61 -80 replies
13/13nvme: Introduce nvmet_target_{setup/cleanup} common codetests/nvme/003 tests/nvme/004 tests/nvme/005 +31 more+138 -4863 replies

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHannes Reinecke
SeriesR-b
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH blktests v3 00/13] Switch to allowed_host

Addressed the comments from v2. I also added cleanup code to _nvmet_cleanup() to make sure we do not leak resources when something goes wrong. I run into this while testing and all tests after the first failure failed then.

changes:
v3:
- added new patch: "nvme/043: Use hostnqn to generate DHCAP key"
- removed unused variable in "nvme/rc: Add helper for adding/removing to allow list"
- added cleanup code to _nvmet_cleanup().

v2:
- updated commit messages
- moved the removal of subsys_name to the right patch
- added _nvmet_target_{setup|cleanup} helpers
this addresses also the 'appears unused' warning by ShellCheck
- https://lore.kernel.org/linux-nvme/[email protected]/

v1:
- initial version
https://lore.kernel.org/linux-nvme/[email protected]/

*** BLURB HERE ***

Daniel Wagner (13):
nvme/{003,004,005,013,046,049}: Group all variables declarations
nvme: Reorganize test preamble code section
nvme/043: Use hostnqn to generate DHCAP key
nvme/rc: Add common subsystem nqn define
nvme: Use def_subsysnqn variable instead local variable nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and
hostid
nvme/rc: Add common file_path name define
nvme: Use def_file_path variable instead local variable nvme/rc: Add common def_subsys_uuid define
nvme: Use def_subsys_uuid variable
nvme/rc: Add helper for adding/removing to allow list
nvme: Add explicitly host to allow_host list
nvme: Introduce nvmet_target_{setup/cleanup} common code

 tests/nvme/003 | 12 ++-----
 tests/nvme/004 | 23 ++++--------
 tests/nvme/005 | 22 +++---------
 tests/nvme/006 | 21 ++---------
 tests/nvme/007 | 19 ++--------
 tests/nvme/008 | 26 +++-----------
 tests/nvme/009 | 21 +++--------
 tests/nvme/010 | 26 +++-----------
 tests/nvme/011 | 22 +++---------
 tests/nvme/012 | 26 +++-----------
 tests/nvme/013 | 22 +++---------
 tests/nvme/014 | 26 +++-----------
 tests/nvme/015 | 21 +++--------
 tests/nvme/016 | 17 +++++----
 tests/nvme/017 | 26 ++++++--------
 tests/nvme/018 | 21 +++--------
 tests/nvme/019 | 26 +++-----------
 tests/nvme/020 | 21 +++--------
 tests/nvme/021 | 21 +++--------
 tests/nvme/022 | 21 +++--------
 tests/nvme/023 | 26 +++-----------
 tests/nvme/024 | 21 +++--------
 tests/nvme/025 | 21 +++--------
 tests/nvme/026 | 21 +++--------
 tests/nvme/027 | 20 +++--------
 tests/nvme/028 | 20 +++--------
 tests/nvme/029 | 26 +++-----------
 tests/nvme/030 | 19 +++++-----
 tests/nvme/031 | 14 ++++----
 tests/nvme/033 |  9 ++---
 tests/nvme/034 |  9 ++---
 tests/nvme/035 |  9 ++---
 tests/nvme/036 |  9 ++---
 tests/nvme/037 |  8 ++---
 tests/nvme/038 |  6 ++--
 tests/nvme/039 |  4 +--
 tests/nvme/040 | 28 +++++----------
 tests/nvme/041 | 49 ++++++++-----------------
 tests/nvme/042 | 55 ++++++++++------------------
 tests/nvme/043 | 52 +++++++++------------------
 tests/nvme/044 | 71 ++++++++++++++----------------------
 tests/nvme/045 | 62 ++++++++++++--------------------
 tests/nvme/046 |  1 +
 tests/nvme/047 | 30 ++++------------
 tests/nvme/048 | 42 +++++++---------------
 tests/nvme/049 |  1 +
 tests/nvme/rc  | 97 +++++++++++++++++++++++++++++++++++++++++++++++---
 47 files changed, 404 insertions(+), 766 deletions(-)
Signature · 1 line
2.41.0