gputop memory usage
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 5 repliesIn review
v2 from the cover letter
* One style tweak, two missing s-o-b, one build failure.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | lib/igt_drm_fdinfo: Parse memory usagelib/ lib/ lib/ +2 more | +166 | 1 reply | |
| 2/3 | lib/igt_drm_clients: Store memory info in the clientlib/ lib/ | +43 | 4 replies | |
| 3/3 | gputop: Add memory informationtools/ | +33 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Kamil Konieczny |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t 0/3] gputop memory usage
From: Tvrtko Ursulin <[email protected]>
Same general approach as with engine utilisation, adding parsing of the relevant fdinfo fields and plumbing to client discovery helpers to finally present some of the available data in gputop:
DRM minor 0
PID MEM RSS render copy video NAME
8098 124M 124M |███████|| || || | neverball 888 76M 75M |▊ || || || | Xorg 966 12M 12M | || || || | xfwm4
Or with Wayland:
DRM minor 0
PID MEM RSS render copy video video-enhance NAME
2093 191M 191M |▊ || || || | gnome-shell
DRM minor 128
PID MEM RSS render copy video video-enhance NAME 2551 71M 71M |██▉ || || || | neverball 2553 50M 50M | || || || | Xwayland
There is probably scope to consolidate some of the igt_drm_fdinfo code and to improve on the presentation but this is a start.
For now, out of the available memory categories, only total and resident are displayed, and also all discovered memory regions are summed up and shown under a single heading.
v2:
* One style tweak, two missing s-o-b, one build failure.
Tvrtko Ursulin (3):
lib/igt_drm_fdinfo: Parse memory usage lib/igt_drm_clients: Store memory info in the client
gputop: Add memory information
lib/igt_drm_clients.c | 35 +++++++++- lib/igt_drm_clients.h | 11 ++++ lib/igt_drm_fdinfo.c | 143 ++++++++++++++++++++++++++++++++++++++-- lib/igt_drm_fdinfo.h | 24 ++++++- tests/i915/drm_fdinfo.c | 8 +-- tools/gputop.c | 34 +++++++++- tools/intel_gpu_top.c | 2 +- 7 files changed, 242 insertions(+), 15 deletions(-)
Signature · 1 line
2.39.2