Skip to content

Fix potential issues for siw

Guoqing Jiang linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5RDMA/siw: Set siw_cm_wq to NULL after it is destroyeddrivers/infiniband/sw/siw/siw_cm.c+3 -10 replies
2/5RDMA/siw: Ensure siw_destroy_cpulist can be called more than oncedrivers/infiniband/sw/siw/siw_main.c+2 -00 replies
3/5RDMA/siw: Initialize siw_link_ops.listdrivers/infiniband/sw/siw/siw_main.c+1 -00 replies
4/5RDMA/siw: Set siw_crypto_shash to NULL after it is freeddrivers/infiniband/sw/siw/siw_main.c+3 -10 replies
5/5RDMA/siw: Don't call wake_up unconditionally in siw_stop_tx_threaddrivers/infiniband/sw/siw/siw_qp_tx.c+6 -10 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBernard Metzler
SeriesA-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Fix potential issues for siw

Hi,

Several issues appeared if we rmmod siw module after failed to insert the module (with manual change like below).

drivers/infiniband/sw/siw/siw_main.c +1 -0
@@ -577,6 +577,7 @@ static __init int siw_init_module(void)
        if (rv)
                goto out_error;
 
+       goto out_error;
        rdma_link_register(&siw_link_ops);
 

Basically, these issues are double free, use before initalization or null pointer dereference. For more details, pls review the individual patch.

Thanks,
Guoqing

Guoqing Jiang (5):
RDMA/siw: Set siw_cm_wq to NULL after it is destroyed RDMA/siw: Ensure siw_destroy_cpulist can be called more than once RDMA/siw: Initialize siw_link_ops.list
RDMA/siw: Set siw_crypto_shash to NULL after it is freed RDMA/siw: Don't call wake_up unconditionally in siw_stop_tx_thread

 drivers/infiniband/sw/siw/siw_cm.c    | 4 +++-
 drivers/infiniband/sw/siw/siw_main.c  | 7 ++++++-
 drivers/infiniband/sw/siw/siw_qp_tx.c | 7 ++++++-
 3 files changed, 15 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1