scsi: qedf: sanitise uaccess
Status from this message: Applied to 6.6/scsi-staging, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 4 repliesApplied
- v13 patches 7 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | scsi: qedf: do not touch __user pointer in qedf_dbg_stop_io_on_error_cmd_read() directlydrivers/ | +3 | 0 replies | |
| 2/3 | scsi: qedf: do not touch __user pointer in qedf_dbg_debug_cmd_read() directlydrivers/ | +3 | 0 replies | |
| 3/3 | scsi: qedf: do not touch __user pointer in qedf_dbg_fp_int_cmd_read() directlydrivers/ drivers/ | +17 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Laurence Oberman | Johannes Thumshirn | Saurav Kashyap |
|---|---|---|---|
| Series | R-b T-b | ||
| 1/3 | R-b T-b | R-b | A-b |
| 2/3 | R-b T-b | R-b | A-b |
| 3/3 | R-b T-b | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/3] scsi: qedf: sanitise uaccess
qedf driver, debugfs part of it specifically, touches __user pointers directly for printing out info to userspace via sprintf(), which may cause crash like this:
BUG: unable to handle kernel paging request at 00007ffd1d6b43a0 IP: [<ffffffffaa7a882a>] string.isra.7+0x6a/0xf0 Oops: 0003 [#1] SMP Call Trace: [<ffffffffaa7a9f31>] vsnprintf+0x201/0x6a0 [<ffffffffaa7aa556>] sprintf+0x56/0x80 [<ffffffffc04227ed>] qedf_dbg_stop_io_on_error_cmd_read+0x6d/0x90 [qedf] [<ffffffffaa65bb2f>] vfs_read+0x9f/0x170 [<ffffffffaa65cb82>] SyS_pread64+0x92/0xc0
Avoid this by preparing the info in a kernel buffer first, either allocated on stack for small printouts, or via vmalloc() for big ones, and then copying it to the userspace properly.
Changes since v1 [1]:
* use scnprintf() for on-stack buffers too
* adjust an on-stack buffer size in qedf_dbg_debug_cmd_read() to be a multiple of 8, and also size it properly
* accumulate acks and reviews
[1] https://lore.kernel.org/lkml/[email protected]/
Oleksandr Natalenko (3):
scsi: qedf: do not touch __user pointer in
qedf_dbg_stop_io_on_error_cmd_read() directly
scsi: qedf: do not touch __user pointer in qedf_dbg_debug_cmd_read()
directly
scsi: qedf: do not touch __user pointer in qedf_dbg_fp_int_cmd_read()
directly
drivers/scsi/qedf/qedf_dbg.h | 2 ++ drivers/scsi/qedf/qedf_debugfs.c | 35 +++++++++++++++++++------------- 2 files changed, 23 insertions(+), 14 deletions(-)
Signature · 1 line
2.41.0