RFC Use Clang for compiling in the 64-bit MSYS2 job
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 25 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | gitlab: remove duplication between msys jobs.gitlab-ci.d/ | +49 | 0 replies | |
| 2/6 | ui/dbus: fix clang compilation issueui/ | +2 | 0 replies | |
| 3/6 | util/oslib-win32: Fix compiling with Clang from MSYS2util/ | +2 | 1 reply | |
| 4/6 | hw/i386/intel_iommu: Fix VTD_IR_TableEntry for ms_struct layouthw/ include/ | +9 | 5 replies | |
| 5/6 | include/qemu/compiler: Fix problem with gcc_struct and Clanginclude/ | +1 | 15 replies | |
| 6/6 | gitlab-ci.d/windows: Use Clang for compiling in the 64-bit MSYS2 job.gitlab-ci.d/ | +8 | 3 replies |
Reviews trailers per patch
2 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Thomas Huth | Philippe Mathieu-Daudé |
|---|---|---|
| 1/6 | ||
| 2/6 | R-b | |
| 3/6 | R-b | |
| 4/6 | ||
| 5/6 | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/6] Use Clang for compiling in the 64-bit MSYS2 job
The 64-bit MSYS2 job often times out in our CI, though we already have limited it to a very minimum by using --without-default-devices etc. GCC is incredibly slow here. By using Clang instead of GCC, the job is ca. 15 minutes faster - that's enough buffer to avoid the timeouts here.
The caveat is that Clang does not support __attribute__((gcc_struct)) on Windows. So we have to make sure that our structs are still padded right. By checking the build with "pahole", Daniel discovered that there is still an issue in VTD_IR_TableEntry, so that's why this struct gets changed in this patch series, too. All other structs did not show a difference with "pahole", so building with Clang should hopefully be fine after these modifications here.
Daniel P. Berrangé (1):
gitlab: remove duplication between msys jobs
Marc-André Lureau (1):
ui/dbus: fix clang compilation issue
Thomas Huth (4):
util/oslib-win32: Fix compiling with Clang from MSYS2 hw/i386/intel_iommu: Fix VTD_IR_TableEntry for ms_struct layout include/qemu/compiler: Fix problem with gcc_struct and Clang gitlab-ci.d/windows: Use Clang for compiling in the 64-bit MSYS2 job
include/hw/i386/intel_iommu.h | 14 ++-- include/qemu/compiler.h | 2 +- hw/i386/intel_iommu.c | 2 +- ui/dbus-listener.c | 3 +- util/oslib-win32.c | 4 +- .gitlab-ci.d/windows.yml | 134 +++++++++++++--------------------- 6 files changed, 65 insertions(+), 94 deletions(-)
Signature · 1 line
2.39.3