Skip to content

fbdev: Use I/O helpers

Thomas Zimmermann dri-devel kvm linux-arm-kernel linux-fbdev linux-media linux-omap 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest47 patches 0 repliesNew
  2. v247 patches 3 repliesSuperseded
  3. v147 patches 10 repliesSuperseded

Changes in v3 from the cover letter

* use _IOMEM_ in commit message

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/47media/vivid: Use fbdev I/O helpersdrivers/media/test-drivers/vivid/Kconfig drivers/media/test-drivers/vivid/vivid-osd.c+2 -60 replies
2/47fbdev/acornfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/acornfb.c+2 -60 replies
3/47fbdev/asiliantfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/asiliantfb.c+2 -60 replies
4/47fbdev/atmel_lcdfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/atmel_lcdfb.c+2 -60 replies
5/47fbdev/aty128fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/aty/aty128fb.c+2 -60 replies
6/47fbdev/carminefb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/carminefb.c+2 -70 replies
7/47fbdev/chipsfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/chipsfb.c+2 -60 replies
8/47fbdev/da8xx-fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/da8xx-fb.c+2 -60 replies
9/47fbdev/efifb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/efifb.c+2 -60 replies
10/47fbdev/fm2fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/fm2fb.c+2 -60 replies
11/47fbdev/fsl-diu-fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/fsl-diu-fb.c+2 -60 replies
12/47fbdev/g364fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/g364fb.c+2 -60 replies
13/47fbdev/geode/gx1fb: Use fbdev I/O helpersdrivers/video/fbdev/geode/Kconfig drivers/video/fbdev/geode/gx1fb_core.c+2 -70 replies
14/47fbdev/geode/gxfb: Use fbdev I/O helpersdrivers/video/fbdev/geode/Kconfig drivers/video/fbdev/geode/gxfb_core.c+2 -70 replies
15/47fbdev/geode/lxfb: Use fbdev I/O helpersdrivers/video/fbdev/geode/Kconfig drivers/video/fbdev/geode/lxfb_core.c+2 -70 replies
16/47fbdev/goldfishfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/goldfishfb.c+2 -60 replies
17/47fbdev/grvga: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/grvga.c+2 -60 replies
18/47fbdev/gxt4500: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/gxt4500.c+2 -60 replies
19/47fbdev/i740fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/i740fb.c+2 -60 replies
20/47fbdev/imxfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/imxfb.c+2 -60 replies
21/47fbdev/kyro: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/kyro/fbdev.c+2 -60 replies
22/47fbdev/macfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/macfb.c+2 -60 replies
23/47fbdev/maxinefb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/maxinefb.c+2 -60 replies
24/47fbdev/mb862xxfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/mb862xx/mb862xxfbdrv.c+2 -60 replies
25/47fbdev/mmpfb: Use fbdev I/O helpersdrivers/video/fbdev/mmp/fb/Kconfig drivers/video/fbdev/mmp/fb/mmpfb.c+2 -60 replies
26/47fbdev/mx3fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/mx3fb.c+2 -60 replies
27/47fbdev/ocfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/ocfb.c+2 -60 replies
28/47fbdev/offb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/offb.c+2 -60 replies
29/47fbdev/omapfb: Use fbdev I/O helpersdrivers/video/fbdev/omap/Kconfig drivers/video/fbdev/omap/omapfb_main.c+2 -60 replies
30/47fbdev/platinumfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/platinumfb.c+2 -60 replies
31/47fbdev/pmag-aa-fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/pmag-aa-fb.c+2 -60 replies
32/47fbdev/pmag-ba-fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/pmag-ba-fb.c+2 -60 replies
33/47fbdev/pmagb-b-fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/pmagb-b-fb.c+2 -60 replies
34/47fbdev/pxa168fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/pxa168fb.c+2 -60 replies
35/47fbdev/pxafb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/pxafb.c+2 -60 replies
36/47fbdev/q40fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/q40fb.c+2 -60 replies
37/47fbdev/s3cfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/s3c-fb.c+2 -60 replies
38/47fbdev/sh7760fb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/sh7760fb.c+2 -60 replies
39/47fbdev/simplefb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/simplefb.c+2 -60 replies
40/47fbdev/sstfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/sstfb.c+2 -60 replies
41/47fbdev/sunxvr1000: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/sunxvr1000.c+2 -60 replies
42/47fbdev/sunxvr2500: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/sunxvr2500.c+2 -60 replies
43/47fbdev/uvesafb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/uvesafb.c+2 -60 replies
44/47fbdev/valkyriefb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/valkyriefb.c+2 -60 replies
45/47fbdev/vesafb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/vesafb.c+2 -60 replies
46/47fbdev/xilinxfb: Use fbdev I/O helpersdrivers/video/fbdev/Kconfig drivers/video/fbdev/xilinxfb.c+2 -60 replies
47/47vfio-dev/mdpy-fb: Use fbdev I/O helperssamples/Kconfig samples/vfio-mdev/mdpy-fb.c+2 -60 replies

Reviews trailers per patch

All 47 patches have a Reviewed-by or Acked-by.

PatchSam RavnborgHelge DellerHans Verkuil
1/47R-b A-b R-b
2/47R-b A-b
3/47R-b A-b
4/47R-b A-b
5/47R-b A-b
6/47R-b A-b
7/47R-b A-b
8/47R-b A-b
9/47R-b A-b
10/47R-b A-b
11/47R-b A-b
12/47R-b A-b
13/47R-b A-b
14/47R-b A-b
15/47R-b A-b
16/47R-b A-b
17/47R-b A-b
18/47R-b A-b
19/47R-b A-b
20/47R-b A-b
21/47R-b A-b
22/47R-b A-b
23/47R-b A-b
24/47R-b A-b
25/47R-b A-b
26/47R-b A-b
27/47R-b A-b
28/47R-b A-b
29/47R-b A-b
30/47R-b A-b
31/47R-b A-b
32/47R-b A-b
33/47R-b A-b
34/47R-b A-b
35/47R-b A-b
36/47R-b A-b
37/47R-b A-b
38/47R-b A-b
39/47R-b A-b
40/47R-b A-b
41/47R-b A-b
42/47R-b A-b
43/47R-b A-b
44/47R-b A-b
45/47R-b A-b
46/47R-b A-b
47/47R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/47] fbdev: Use I/O helpers

Most fbdev drivers operate on I/O memory. And most of those use the default implementations for file I/O and console drawing. Convert all these low-hanging fruits to the fb_ops initializer macro and Kconfig token for fbdev I/O helpers.

The fbdev I/O helpers are easily grep-able. In a later patch, they can be left to empty values if the rsp. functionality, such as file I/O or console, has been disabled.

There are no functional changes. The helpers set the defaults that the drivers already use. The fb_io_*() functions that the initializer macro sets are the defaults if struct fb_ops.fb_read or .fb_write are NULL. After all drivers have been updated to set them explicitly, the defaults can be dropped and the functions can be made optional.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Thomas Zimmermann (47):
media/vivid: Use fbdev I/O helpers
fbdev/acornfb: Use fbdev I/O helpers
fbdev/asiliantfb: Use fbdev I/O helpers
fbdev/atmel_lcdfb: Use fbdev I/O helpers
fbdev/aty128fb: Use fbdev I/O helpers
fbdev/carminefb: Use fbdev I/O helpers
fbdev/chipsfb: Use fbdev I/O helpers
fbdev/da8xx-fb: Use fbdev I/O helpers
fbdev/efifb: Use fbdev I/O helpers
fbdev/fm2fb: Use fbdev I/O helpers
fbdev/fsl-diu-fb: Use fbdev I/O helpers
fbdev/g364fb: Use fbdev I/O helpers
fbdev/geode/gx1fb: Use fbdev I/O helpers
fbdev/geode/gxfb: Use fbdev I/O helpers
fbdev/geode/lxfb: Use fbdev I/O helpers
fbdev/goldfishfb: Use fbdev I/O helpers
fbdev/grvga: Use fbdev I/O helpers
fbdev/gxt4500: Use fbdev I/O helpers
fbdev/i740fb: Use fbdev I/O helpers
fbdev/imxfb: Use fbdev I/O helpers
fbdev/kyro: Use fbdev I/O helpers
fbdev/macfb: Use fbdev I/O helpers
fbdev/maxinefb: Use fbdev I/O helpers
fbdev/mb862xxfb: Use fbdev I/O helpers
fbdev/mmpfb: Use fbdev I/O helpers
fbdev/mx3fb: Use fbdev I/O helpers
fbdev/ocfb: Use fbdev I/O helpers
fbdev/offb: Use fbdev I/O helpers
fbdev/omapfb: Use fbdev I/O helpers
fbdev/platinumfb: Use fbdev I/O helpers
fbdev/pmag-aa-fb: Use fbdev I/O helpers
fbdev/pmag-ba-fb: Use fbdev I/O helpers
fbdev/pmagb-b-fb: Use fbdev I/O helpers
fbdev/pxa168fb: Use fbdev I/O helpers
fbdev/pxafb: Use fbdev I/O helpers
fbdev/q40fb: Use fbdev I/O helpers
fbdev/s3cfb: Use fbdev I/O helpers
fbdev/sh7760fb: Use fbdev I/O helpers
fbdev/simplefb: Use fbdev I/O helpers
fbdev/sstfb: Use fbdev I/O helpers
fbdev/sunxvr1000: Use fbdev I/O helpers
fbdev/sunxvr2500: Use fbdev I/O helpers
fbdev/uvesafb: Use fbdev I/O helpers
fbdev/valkyriefb: Use fbdev I/O helpers
fbdev/vesafb: Use fbdev I/O helpers
fbdev/xilinxfb: Use fbdev I/O helpers
vfio-dev/mdpy-fb: Use fbdev I/O helpers

 drivers/media/test-drivers/vivid/Kconfig     |   4 +-
 drivers/media/test-drivers/vivid/vivid-osd.c |   4 +-
 drivers/video/fbdev/Kconfig                  | 160 +++++--------------
 drivers/video/fbdev/acornfb.c                |   4 +-
 drivers/video/fbdev/asiliantfb.c             |   4 +-
 drivers/video/fbdev/atmel_lcdfb.c            |   4 +-
 drivers/video/fbdev/aty/aty128fb.c           |   4 +-
 drivers/video/fbdev/carminefb.c              |   5 +-
 drivers/video/fbdev/chipsfb.c                |   4 +-
 drivers/video/fbdev/da8xx-fb.c               |   4 +-
 drivers/video/fbdev/efifb.c                  |   4 +-
 drivers/video/fbdev/fm2fb.c                  |   4 +-
 drivers/video/fbdev/fsl-diu-fb.c             |   4 +-
 drivers/video/fbdev/g364fb.c                 |   4 +-
 drivers/video/fbdev/geode/Kconfig            |  12 +-
 drivers/video/fbdev/geode/gx1fb_core.c       |   5 +-
 drivers/video/fbdev/geode/gxfb_core.c        |   5 +-
 drivers/video/fbdev/geode/lxfb_core.c        |   5 +-
 drivers/video/fbdev/goldfishfb.c             |   4 +-
 drivers/video/fbdev/grvga.c                  |   4 +-
 drivers/video/fbdev/gxt4500.c                |   4 +-
 drivers/video/fbdev/i740fb.c                 |   4 +-
 drivers/video/fbdev/imxfb.c                  |   4 +-
 drivers/video/fbdev/kyro/fbdev.c             |   4 +-
 drivers/video/fbdev/macfb.c                  |   4 +-
 drivers/video/fbdev/maxinefb.c               |   4 +-
 drivers/video/fbdev/mb862xx/mb862xxfbdrv.c   |   4 +-
 drivers/video/fbdev/mmp/fb/Kconfig           |   4 +-
 drivers/video/fbdev/mmp/fb/mmpfb.c           |   4 +-
 drivers/video/fbdev/mx3fb.c                  |   4 +-
 drivers/video/fbdev/ocfb.c                   |   4 +-
 drivers/video/fbdev/offb.c                   |   4 +-
 drivers/video/fbdev/omap/Kconfig             |   4 +-
 drivers/video/fbdev/omap/omapfb_main.c       |   4 +-
 drivers/video/fbdev/platinumfb.c             |   4 +-
 drivers/video/fbdev/pmag-aa-fb.c             |   4 +-
 drivers/video/fbdev/pmag-ba-fb.c             |   4 +-
 drivers/video/fbdev/pmagb-b-fb.c             |   4 +-
 drivers/video/fbdev/pxa168fb.c               |   4 +-
 drivers/video/fbdev/pxafb.c                  |   4 +-
 drivers/video/fbdev/q40fb.c                  |   4 +-
 drivers/video/fbdev/s3c-fb.c                 |   4 +-
 drivers/video/fbdev/sh7760fb.c               |   4 +-
 drivers/video/fbdev/simplefb.c               |   4 +-
 drivers/video/fbdev/sstfb.c                  |   4 +-
 drivers/video/fbdev/sunxvr1000.c             |   4 +-
 drivers/video/fbdev/sunxvr2500.c             |   4 +-
 drivers/video/fbdev/uvesafb.c                |   4 +-
 drivers/video/fbdev/valkyriefb.c             |   4 +-
 drivers/video/fbdev/vesafb.c                 |   4 +-
 drivers/video/fbdev/xilinxfb.c               |   4 +-
 samples/Kconfig                              |   4 +-
 samples/vfio-mdev/mdpy-fb.c                  |   4 +-
 53 files changed, 94 insertions(+), 286 deletions(-)

base-commit: 194cd63362db9ed2cbdd3deaa7a8752b86d95f3b
prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: cbc453ee02fae02af22fbfdce56ab732c7a88c36
prerequisite-patch-id: 9e45f32f01ebd4d3a927038e52b91a389673b9bb
prerequisite-patch-id: b0b735b6e10a12816cea5ea15e3292c6342ed2f2
prerequisite-patch-id: 3997b2a71240d34ccf6990cf133cad39d4efc8f4
prerequisite-patch-id: d64b3896ffd91137df0c4311a8b7aa0d5fa40a11
prerequisite-patch-id: 5c8669f6947f5a44d19f4f8bd36b77c31163eda7

Signature · 1 line
2.41.0