histograms: Fix memory leak, logic bugs, legibility
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 8 repliesIn review
- v35 of 6 patches 12 repliesSuperseded
- v25 patches 11 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 5 patches | 18 replies | Superseded |
Changes in v4 from the cover letter
* Reorder enum traceeval_data_type numeric types for algorithmic access.
* Reorder union traceeval_data numeric fields for legibility.
* Remove parenthesis from function name in kerneldocs.
* Optimize logic in type_alloc().
* Distinguish internal vs public interfaces within include statements.
* Rework copy_traceeval_data() logic for legibility.
* Rework comparator return types to fix query and insert bugs.
* update_entry() frees the entries old values to avoid a memory leak.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | histograms: Initial histograms interfaceinclude/ | +130 | 1 reply | |
| 2/5 | histograms: Add traceeval initialize and releaseMakefile include/ src/ +1 more | +324 | 1 reply | |
| 3/5 | histograms: Add traceeval compareinclude/ src/ | +230 | 0 replies | |
| 4/5 | histograms: Add traceeval queryinclude/ src/ | +167 | 2 replies | |
| 5/5 | histograms: Add traceeval insertinclude/ src/ | +118 | 1 reply |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ross Zwisler |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] histograms: Fix memory leak, logic bugs, legibility
From: Stevie Alvarez (Google) <[email protected]>
Changes in v4:
* Reorder enum traceeval_data_type numeric types for algorithmic access.
* Reorder union traceeval_data numeric fields for legibility.
* Remove parenthesis from function name in kerneldocs.
* Optimize logic in type_alloc().
* Distinguish internal vs public interfaces within include statements.
* Rework copy_traceeval_data() logic for legibility.
* Rework comparator return types to fix query and insert bugs.
* update_entry() frees the entries old values to avoid a memory leak.
Steven, I didn't get around to adding in the cstring field to traceeval_data, as I wasn't able to completely grasp what you were looking for. My apologies.
---
v3 discussion: https://lore.kernel.org/linux-trace-devel/20230808180156.GA1300@3xKetch/T/#t
Stevie Alvarez (Google) (5):
histograms: Initial histograms interface
histograms: Add traceeval initialize and release
histograms: Add traceeval compare
histograms: Add traceeval query
histograms: Add traceeval insert
Makefile | 2 +- include/traceeval-hist.h | 147 +++++++ include/traceeval-test.h | 16 + src/Makefile | 1 + src/histograms.c | 804 +++++++++++++++++++++++++++++++++++++++ 5 files changed, 969 insertions(+), 1 deletion(-) create mode 100644 include/traceeval-hist.h create mode 100644 include/traceeval-test.h create mode 100644 src/histograms.c
Signature · 1 line
2.41.0