Skip to content

Fix alignment issue and prepare for rust 1.71

Boqun Feng linux-mm lkml oe-kbuild-all rust-for-linux stable 1 version Applied

Status from this message: Applied to `rust-fixes`, but please feel free to send `Reviewed-by`s.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 9 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3rust: allocator: Prevent mis-aligned allocationrust/bindings/bindings_helper.h rust/kernel/allocator.rs+60 -156 replies
2/3rust: allocator: Use krealloc_aligned() in KernelAllocator::allocrust/kernel/allocator.rs+3 -31 reply
3/3rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc implrust/kernel/allocator.rs+27 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchVlastimil BabkaAndreas Hindborg
1/3A-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Fix alignment issue and prepare for rust 1.71

Hi Miguel,

I end up with this series:

(background: https://lore.kernel.org/rust-for-linux/CANiq72=pb18B6NOcXF03d0ctOP8kv2dqnUeNyEuSvuDb=vs-0g@mail.gmail.com/)

Patch #1: introduces the core helper function that help calculate the correct size for krealloc(), and also use the helper function to fix __rust_* ones, this should be backported to stable kernels hence the Cc.

Patch #2: use the helper function in KernelAllocator

Patch #3: Bjorn's patch with correct use of the helper function.

I have to add a few more SAFETY comments in these __rust_* functions, which may cause conflict with your 1.71 series.

Since all previous patches get refactored a bit, I dropped all the Reviewed-bys, appreciate anyone to take a look, thanks!

Regards,
Boqun

Björn Roy Baron (1):
rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl

Boqun Feng (2):
rust: allocator: Prevent mis-aligned allocation
rust: allocator: Use krealloc_aligned() in KernelAllocator::alloc

 rust/bindings/bindings_helper.h |   1 +
 rust/kernel/allocator.rs        | 107 ++++++++++++++++++++++++++------
 2 files changed, 90 insertions(+), 18 deletions(-)
Signature · 1 line
2.41.0